Initial implementation of SVS Runtime package #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanglaser
reviewed
Oct 31, 2025
…allow non-LTO linking
…el/ScalableVectorSearch into rfsaliev/cpp-runtime-binding
aguerreb
reviewed
Nov 5, 2025
bindings/cpp/include/vamana_index.h
Outdated
| }; | ||
|
|
||
| // TODO: | ||
| // 1. Should StorageKind, metric, be a part of BuildParams? |
Contributor
There was a problem hiding this comment.
StorageKind and metric should not be part of BuildParams. We use DataType and QueryType in SVS for storage kinds. If it's possible we can stick to those.
Member
Author
There was a problem hiding this comment.
Made StorageKind globally defined by moving svs::runtime namespace in IndexSVSImplDefs.h.
aguerreb
reviewed
Nov 5, 2025
aguerreb
reviewed
Nov 5, 2025
aguerreb
reviewed
Nov 5, 2025
aguerreb
reviewed
Nov 5, 2025
aguerreb
reviewed
Nov 5, 2025
bindings/cpp/include/vamana_index.h
Outdated
| }; | ||
|
|
||
| struct SearchParams { | ||
| size_t search_window_size = 0; |
Contributor
There was a problem hiding this comment.
We should add the two prefetching parameters here. Even if those will be kept to default values in general, it'd be good to have them here.
I think this produces more readable code. And since `runtime_error_wrapper()` is an internal function, there shouldn't be any disadvantages for the shared lib.
rfsaliev
requested review from
Alexsandruss,
ahuber21,
dian-lun-lin,
homksei,
ibhati and
yuejiaointel
as code owners
ethanglaser
reviewed
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.