Refactor poolbuffer check to fix refcount issue when using clang comp… #860
+17
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iler The issue root-caused to the subtle difference of unique_ptr's destructor between clang and gcc: Clang (libc++): Calls unique_ptr's destructor, which first clears the internal pointer to nullptr and then calls the deleter on the old pointer value. This means that within the destructor of the managed object, the owning unique_ptr's internal pointer is already nullified. GCC (libstdc++): The destructor directly calls the deleter on the current pointer without first setting it to nullptr Fix: using flag-based system to replace the problematic pointer comparison ref intel#744 Signed-off-by: Mi, Yanfeng <yanfeng.mi@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…iler
The issue root-caused to the subtle difference of unique_ptr's destructor between clang and gcc:
Clang (libc++): Calls unique_ptr's destructor, which first clears the internal pointer to nullptr and then calls the deleter on the old pointer value. This means that within the destructor of the managed object, the owning unique_ptr's internal pointer is already nullified.
GCC (libstdc++): The destructor directly calls the deleter on the current pointer without first setting it to nullptr
Fix: using flag-based system to replace the problematic pointer comparison ref #744