Implement line length and breaking rules #109
Conversation
jvsqzj
changed the title
jvsqzj
force-pushed
the
feature/73-line-breaking
branch
from
a36462e to
d9bb070
Compare
jvsqzj
force-pushed
the
feature/73-line-breaking
branch
from
d9bb070 to
3110e82
Compare
me-cr
force-pushed
the
feature/73-line-breaking
branch
7 times, most recently
from
b934564 to
cca1d93
Compare
me-cr
force-pushed
the
feature/73-line-breaking
branch
2 times, most recently
from
ed9dae7 to
faf5b2a
Compare
jvsqzj
force-pushed
the
feature/73-line-breaking
branch
3 times, most recently
from
308ee69 to
18a10ea
Compare
* Add MethodOutputBreak (LL5) Rule
* Add LL3 rule for conditional expression breaking * Cover more test cases * Add ll3 to features.md * Add to example_lint_cfg
jvsqzj
force-pushed
the
feature/73-line-breaking
branch
from
18a10ea to
d9825d1
Compare
| ``` | ||
| x = (a_very_long_expression | ||
| + another_very_long_expression) | ||
| * a_third_long_expression; |
There was a problem hiding this comment.
indentation error in example?
| # Change Log | ||
|
|
||
| ## 0.9.14 | ||
| - Added support for line length and breaking rules break_func_call_open_paren, break_method_output, break_conditional_expression and break_before_binary_op. |
There was a problem hiding this comment.
Should probably primarily focus on user-friendly version of description of what linting has improved (this is allowed to be vague, or just a reference to the rule number in-doc), followed by the identifier of the linting rules (this is still valuable feedback, as these now also appear in linting messages)
| structure::{MethodContent, ObjectStatementsContent}, | ||
| tree::TreeElementTokenIterator, | ||
| types::{BitfieldsContent, LayoutContent, StructTypeContent}}; | ||
| use crate::analysis::parsing::{expression::{CastContent, FunctionCallContent, ParenExpressionContent}, lexer::TokenKind, parser::Token, statement::{self, CompoundContent, DoContent, ForContent, ForeachContent, IfContent, StatementContent, SwitchCase, SwitchContent, WhileContent}, structure::{DMLObjectContent, MethodContent, ObjectStatementsContent}, tree::TreeElementTokenIterator, types::{BitfieldsContent, LayoutContent, StructTypeContent}}; |
There was a problem hiding this comment.
This change to the import indentation is a downgrade, and I am not sure what prompted it? IMO I think using multiple branches of sub-modules in an import a little awkward (so I'd prefer multiple lines all starting with "crate::analysis::parsing::") , but I'd accept this as it was pre-change.
| let mut tokens = node.tokens(); | ||
| Self::filter_out_last_semi_ranges(&mut tokens); | ||
| return Some(IndentContinuationLineArgs { | ||
| token_list: IndentParenExprArgs::filter_out_parenthesized_tokens(tokens), |
There was a problem hiding this comment.
slight indentation error
| || ! IndentParenExprArgs::is_broken_after_lparen( | ||
| node.lparen.range(), | ||
| filtered_member_ranges.first()?.to_owned()) { | ||
| return None |
There was a problem hiding this comment.
Missing semicolon in return statement
5 participants
This PR introduces Line Length and Breaking style rules to the lint module. It also covers rule IN6 which was left out of scope for previous Indentation rules patch and had important implications for line length implementation.