Capture and log unknown fields from config file #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonatanWaern
reviewed
Aug 1, 2025
jvsqzj
reviewed
Aug 7, 2025
me-cr
force-pushed
the
fix/config-file-unknown-fields
branch
from
58e2923 to
2bf7e6e
Compare
jvsqzj
reviewed
Aug 14, 2025
jvsqzj
reviewed
Aug 14, 2025
5 tasks
me-cr
force-pushed
the
fix/config-file-unknown-fields
branch
3 times, most recently
from
2e59830 to
74498f2
Compare
me-cr
force-pushed
the
fix/config-file-unknown-fields
branch
3 times, most recently
from
4fd2a32 to
bd568da
Compare
me-cr
force-pushed
the
fix/config-file-unknown-fields
branch
from
bd568da to
e47e02c
Compare
jvsqzj
approved these changes
Sep 29, 2025
JonatanWaern
approved these changes
Sep 30, 2025
There was a problem hiding this comment.
@me-cr Reminder that rebases on main, rather than merges from main, are preferred here
alecalvop
reviewed
Oct 8, 2025
| if let Some(file_watch) = FileWatch::new(ctx) { | ||
| if params.changes.iter().any(|c| file_watch.is_relevant(c)) { | ||
| ctx.update_compilation_info(&out); | ||
| ctx.update_linter_config(&out); |
There was a problem hiding this comment.
@JonatanWaern We were considering adding linting config file to FileWatch, but I found that an effort was being made in this PR: #122. Are you planning on working on this?
There was a problem hiding this comment.
Yes, eventually I will take a second(third?) look at making file watching work properly. ATM it is entirely non-functional and my previous attempts didn't result in a clear cause. It is not a high priority atm, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capture unknown fields using Serde’s flatten attribute. This approach allows us to accept valid input, ignore unknown fields during normal operation, and log them as needed, instead of rejecting them and using default configuration values.
@jvsqzj
@alecalvop