Skip to content

[SYCL][Clang] Add sentinel value to kernel_args_sizes #20540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: sycl
Choose a base branch
from
+11 −7
Open

[SYCL][Clang] Add sentinel value to kernel_args_sizes #20540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb94687
[SYCL][Clang] Add sentinel value to kernel_args_sizes
elizabethandrews Nov 3, 2025
e1e1c74
Change sentinel value to 0 to avoid type change and ABI break
elizabethandrews Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions clang/lib/Sema/SemaSYCL.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7056,7 +7056,11 @@ void SYCLIntegrationHeader::emit(raw_ostream &O) {
for (unsigned I = 0; I < KernelDescs.size(); I++) {
O << KernelDescs[I].Params.size() << ", ";
}
// Add a sentinel to avoid warning if the collection is empty
// (similar to what we do for kernel_signatures below).
O << "0, \n";
O << "};\n\n";

O << "// array representing signatures of all kernels defined in the\n";
O << "// corresponding source\n";
O << "static constexpr\n";
Expand Down
2 changes: 1 addition & 1 deletion clang/test/CodeGenSYCL/int-header-empty-signatures.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
// CHECK-NEXT: ""
// CHECK-NEXT: };

// CHECK: static constexpr unsigned kernel_args_sizes[] = {
// CHECK: static constexpr unsigned kernel_args_sizes[] = {0, 0

// CHECK: static constexpr
// CHECK-NEXT: const kernel_param_desc_t kernel_signatures[] = {
Expand Down
2 changes: 1 addition & 1 deletion clang/test/CodeGenSYCL/integration_header.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
// CHECK-NEXT: ""
// CHECK-NEXT: };
//
// CHECK: static constexpr unsigned kernel_args_sizes[] = {
// CHECK: static constexpr unsigned kernel_args_sizes[] = {5, 3, 2, 8, 3, 0, 0,
//
// CHECK: static constexpr
// CHECK-NEXT: const kernel_param_desc_t kernel_signatures[] = {
Expand Down
2 changes: 1 addition & 1 deletion clang/test/CodeGenSYCL/kernel-param-acc-array-ih.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
// CHECK-NEXT: ""
// CHECK-NEXT: };

// CHECK: static constexpr unsigned kernel_args_sizes[] = {
// CHECK: static constexpr unsigned kernel_args_sizes[] = {2, 0,

// CHECK: static constexpr
// CHECK-NEXT: const kernel_param_desc_t kernel_signatures[] = {
Expand Down
2 changes: 1 addition & 1 deletion clang/test/CodeGenSYCL/kernel-param-member-acc-array-ih.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
// CHECK-NEXT: ""
// CHECK-NEXT: };

// CHECK: static constexpr unsigned kernel_args_sizes[] = {
// CHECK: static constexpr unsigned kernel_args_sizes[] = {2, 0,

// CHECK: static constexpr
// CHECK-NEXT: const kernel_param_desc_t kernel_signatures[] = {
Expand Down
2 changes: 1 addition & 1 deletion clang/test/CodeGenSYCL/kernel-param-pod-array-ih.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
// CHECK-NEXT: ""
// CHECK-NEXT: };

// CHECK: static constexpr unsigned kernel_args_sizes[] = {
// CHECK: static constexpr unsigned kernel_args_sizes[] = {1, 1, 1, 0,

// CHECK: static constexpr
// CHECK-NEXT: const kernel_param_desc_t kernel_signatures[] = {
Expand Down
2 changes: 1 addition & 1 deletion clang/test/CodeGenSYCL/union-kernel-param-ih.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
// CHECK-NEXT: ""
// CHECK-NEXT: };

// CHECK: static constexpr unsigned kernel_args_sizes[] = {
// CHECK: static constexpr unsigned kernel_args_sizes[] = {1, 0,

// CHECK: static constexpr
// CHECK-NEXT: const kernel_param_desc_t kernel_signatures[] = {
Expand Down
2 changes: 1 addition & 1 deletion clang/test/CodeGenSYCL/wrapped-accessor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
// CHECK-NEXT: ""
// CHECK-NEXT: };

// CHECK: static constexpr unsigned kernel_args_sizes[] = {
// CHECK: static constexpr unsigned kernel_args_sizes[] = {1, 0,

// CHECK: static constexpr
// CHECK-NEXT: const kernel_param_desc_t kernel_signatures[] = {
Expand Down