[SYCL][Graph] Graph duplication optimizations in finalize() #20547
+95
−89
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When invoking
auto g = graph.finalize()on a graph with a moderate amount of nodes, duplicating the nodes of the modifiable graph into the executable graph takes a non-trivial amount of time. This PR introduces a few changes to improve the performance ofduplicateNodes():std::dequeuewith astd::vectorso that it can be directly moved, omitting unnecessary O(n) allocationsreserve()for the vector of nodes and map that we are going to create, since we know the total number of nodes.The changes for 2. make the diff seem much larger than it actually is, but the majority of it is whitespace from moving the subgraph handling into an if statement.