Skip to content

[UR] Do not call addPendingMemoryAllocation() in appendKernelLaunchWithArgsExpNew() #20549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: sycl
Choose a base branch
from
Open

[UR] Do not call addPendingMemoryAllocation() in appendKernelLaunchWithArgsExpNew() #20549

wants to merge 1 commit into from
+59 −49

Conversation

@ldorau
Copy link
Contributor

@ldorau ldorau commented Nov 4, 2025 •
edited
Loading

Do not call addPendingMemoryAllocation() in appendKernelLaunchWithArgsExpNew().
It is an optimization - it removes adding new elements to the pending_allocations vector.

@ldorau ldorau force-pushed the Remove_addPendingMemoryAllocation_from_appendKernelLaunchWithArgsExpNew branch from a72b489 to 0fa4d7c Compare November 5, 2025 09:51
@ldorau ldorau changed the title Remove addPendingMemoryAllocation() from appendKernelLaunchWithArgsExpNew() Do not call addPendingMemoryAllocation() in appendKernelLaunchWithArgsExpNew() Nov 5, 2025
@ldorau ldorau changed the title Do not call addPendingMemoryAllocation() in appendKernelLaunchWithArgsExpNew() [UR] Do not call addPendingMemoryAllocation() in appendKernelLaunchWithArgsExpNew() Nov 5, 2025
@ldorau ldorau requested review from kswiecicki and pbalcer November 5, 2025 10:05
@ldorau
Copy link
Contributor Author

ldorau commented Nov 5, 2025

Benchmark: https://github.com/intel/llvm/actions/runs/19098018371

@ldorau ldorau marked this pull request as ready for review November 5, 2025 10:29
@ldorau ldorau requested a review from a team as a code owner November 5, 2025 10:29
@ldorau
Do not call addPendingMemoryAllocation() in appendKernelLaunchWithArg…
0fa4d7c 
…sExpNew()

Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
@ldorau
Copy link
Contributor Author

ldorau commented Nov 5, 2025

It is an optimization - it removes adding new elements to the pending_allocations vector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pbalcer pbalcer Awaiting requested review from pbalcer

@kswiecicki kswiecicki Awaiting requested review from kswiecicki

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ldorau