-
Notifications
You must be signed in to change notification settings - Fork 796
[clang][SYCL] Fix field/base builtins for PCH support #20560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sycl
Are you sure you want to change the base?
Conversation
We have added several builtins for device copyability checking a while back. These are implemented via new AST nodes, so they require implementation of ASTReaderStmt's and ASTWriterStmt's methods. The implementation was in place but it was untested so we never saw that it is missing reading of the builtin expression's type which resulted in crashes during PCH reading.
|
Failed tests on PVC are unrelated. The change can only break something for all devices and I'm pretty sure we don't have PCH related tests anywhere. |
Can you please update llvm/sycl/test-e2e/PerformanceTests/KernelCompiler/auto-pch.cpp Lines 97 to 105 in 0f39e01
to include run({"sycl/sycl.hpp"}); at the very end. |
I forgot to mention that this test requires a label to run in pre-commit CI. I've added it and closed/re-opened the PR to re-trigger pre-commit CI. |
|
@intel/llvm-gatekeepers please consider merging |
We have added several builtins for device copyability checking a while back. These are implemented via new AST nodes, so they require implementation of ASTReaderStmt's and ASTWriterStmt's methods. The implementation was in place but it was untested so we never saw that it is missing writing/reading of the builtin expression's type which resulted in crashes during PCH reading.