Skip to content

Conversation

@Fznamznon
Copy link
Contributor

We have added several builtins for device copyability checking a while back. These are implemented via new AST nodes, so they require implementation of ASTReaderStmt's and ASTWriterStmt's methods. The implementation was in place but it was untested so we never saw that it is missing writing/reading of the builtin expression's type which resulted in crashes during PCH reading.

We have added several builtins for device copyability checking a while
back. These are implemented via new AST nodes, so they require
implementation of ASTReaderStmt's and ASTWriterStmt's methods. The
implementation was in place but it was untested so we never saw that it
is missing reading of the builtin expression's type which resulted in
crashes during PCH reading.
@Fznamznon
Copy link
Contributor Author

Failed tests on PVC

Failed Tests (8):
  SYCL :: Adapters/level_zero/event-leak.cpp
  SYCL :: Adapters/level_zero/imm_cmdlist.cpp
  SYCL :: Adapters/level_zero/interop-thread.cpp
  SYCL :: Adapters/level_zero/interop.cpp
  SYCL :: Adapters/level_zero/interop_memcpy.cpp
  SYCL :: Adapters/level_zero/track_indirect_access_memory.cpp
  SYCL :: DeviceImageBackendContent/L0_interop_test.cpp
  SYCL :: Regression/barrier_waitlist_with_interop_event.cpp

are unrelated. The change can only break something for all devices and I'm pretty sure we don't have PCH related tests anywhere.

@aelovikov-intel
Copy link
Contributor

I'm pretty sure we don't have PCH related tests anywhere

Can you please update

run({});
run({"sycl/half_type.hpp"});
run({"sycl/ext/oneapi/bfloat16.hpp"});
run({"sycl/marray.hpp"});
run({"sycl/vector.hpp"});
run({"sycl/multi_ptr.hpp"});
run({"sycl/builtins.hpp"});
run({"sycl/ext/oneapi/matrix/matrix.hpp"});
}

to include

run({"sycl/sycl.hpp"}); 

at the very end.

@Fznamznon Fznamznon requested a review from a team as a code owner November 5, 2025 17:50
@aelovikov-intel aelovikov-intel added the run-perf-tests Run performance tests in pre-commit (normally part of post-commit only) label Nov 5, 2025
@aelovikov-intel
Copy link
Contributor

aelovikov-intel commented Nov 5, 2025

Can you please update

I forgot to mention that this test requires a label to run in pre-commit CI. I've added it and closed/re-opened the PR to re-trigger pre-commit CI.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

@intel/llvm-gatekeepers please consider merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-perf-tests Run performance tests in pre-commit (normally part of post-commit only)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants