Skip to content

WIP-v.1.0.4 #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+11 −11
Open

WIP-v.1.0.4 #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f48c2ba
update node-addon-api and version
esnyder1 Nov 5, 2025
dff29c8
update version number
esnyder1 Nov 5, 2025
ccf473d
mark parameters as const
esnyder1 Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@intelcorp/wmi-native-module",
"version": "1.0.3",
"version": "1.0.4",
"description": "WMI Native Module",
"main": "index.js",
"repository": {
Expand All @@ -11,7 +11,7 @@
"contributors": [],
"license": "MIT",
"dependencies": {
"node-addon-api": "^8.2.1"
"node-addon-api": "^8.5.0"
},
"scripts": {
"install": "node-gyp rebuild"
Expand Down
14 changes: 7 additions & 7 deletions src/wmi_wrapper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ namespace wmi_wrapper
}

std::wstring GetPropertyValue(
std::wstring property,
const std::wstring &property,
IWbemClassObject *class_object)
{
HRESULT hres;
Expand Down Expand Up @@ -148,7 +148,7 @@ namespace wmi_wrapper
}

HRESULT GetAllValues(
std::wstring query,
const std::wstring &query,
std::vector<std::wstring> properties,
std::vector<WmiQueryResult> *results,
IWbemServices *service)
Expand Down Expand Up @@ -223,11 +223,11 @@ namespace wmi_wrapper
// Initialize COM.
hres = CoInitializeEx(0, COINIT_MULTITHREADED);
{
if (FAILED(hres) && hres == RPC_E_CHANGED_MODE)
{
// Was already initialized in a different mode, switch
hres = CoInitializeEx(0, COINIT_APARTMENTTHREADED);
}
if (FAILED(hres) && hres == RPC_E_CHANGED_MODE)
{
// Was already initialized in a different mode, switch
hres = CoInitializeEx(0, COINIT_APARTMENTTHREADED);
}
if (FAILED(hres))
{
// Failed to initialize COM library
Expand Down
4 changes: 2 additions & 2 deletions src/wmi_wrapper.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ namespace wmi_wrapper
typedef std::vector<std::pair<std::wstring, std::wstring>> WmiQueryResult;
typedef std::pair<std::wstring, std::vector<std::wstring>> WmiQueryParams;

std::wstring GetPropertyValue(std::wstring property, IWbemClassObject *class_object);
HRESULT GetAllValues(std::wstring query, std::vector<std::wstring> properties, std::vector<WmiQueryResult> *results, IWbemServices *service);
std::wstring GetPropertyValue(const std::wstring &property, IWbemClassObject *class_object);
HRESULT GetAllValues(const std::wstring &query, std::vector<std::wstring> properties, std::vector<WmiQueryResult> *results, IWbemServices *service);
HRESULT GetPropertyValues(std::vector<std::wstring> properties, WmiQueryResult *results, IWbemClassObject *class_object);
HRESULT GetAllPropertyValues(IWbemClassObject *class_object, WmiQueryResult *results);
HRESULT Query(const char *wmi_namespace, WmiQueryParams query, std::vector<WmiQueryResult> *results);
Expand Down