Skip to content

Conversation

@peruibeloko
Copy link
Contributor

No description provided.

Copy link
Member

@nazarepiedady nazarepiedady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peruibeloko, could you evaluate the review I did?

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@peruibeloko
Copy link
Contributor Author

/done

Copy link
Member

@nazarepiedady nazarepiedady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is ready to be applied.

@nazarepiedady
Copy link
Member

@danilolmc, @jonnathan-ls, could you help to review this pull request and approve it if it is okay?

Copy link
Contributor

@danilolmc danilolmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Droped just a single comment, not a big deal!

The PR LGTM!

@peruibeloko
Copy link
Contributor Author

@nazarepiedady Implemented the change, we're able to merge now!

@nazarepiedady
Copy link
Member

@peruibeloko, I need one person to approve the updates, this person does not need necessarily to be a maintainer, a regular contributor serves.

@nazarepiedady
Copy link
Member

@danilolmc, do you have time to approve these updates?

@nazarepiedady
Copy link
Member

@jonnathan-ls, could you approve these updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants