🐛 setup-envtest: select the newest Kubernetes by default

[cbandy]

This fixes #3379.

$ (cd ./tools/setup-envtest && go run . use --print=overview 1.34.0)
Version: 1.34.0
OS/Arch: linux/arm64
$ (cd ./tools/setup-envtest && go run . use --print=overview 1.34.1)
Version: 1.34.1
OS/Arch: linux/arm64
$ (cd ./tools/setup-envtest && go run . use --print=overview 1.34.x)
Version: 1.34.1 👈
OS/Arch: linux/arm64

No version requested, before, oldest version selected:

$ go run sigs.k8s.io/controller-runtime/tools/setup-envtest@latest cleanup
$ go run sigs.k8s.io/controller-runtime/tools/setup-envtest@latest use --print=overview
Version: 1.23.5 👈
OS/Arch: linux/arm64

No version requested, after, newest version selected:

$ (cd ./tools/setup-envtest && go run . cleanup)
$ (cd ./tools/setup-envtest && go run . use --print=overview)
Version: 1.34.1 👈
OS/Arch: linux/arm64

Tests are passing:

$ (cd ./tools/setup-envtest && go run github.com/onsi/ginkgo/v2/ginkgo run -r)
[1762277962] Env Suite - 7/7 specs ••••••• SUCCESS! 537.459µs PASS
[1762277962] Store Suite - 15/15 specs ••••••••••••••• SUCCESS! 7.15825ms PASS
[1762277962] Test Version Suite - 2/2 specs •• SUCCESS! 215.458µs PASS
[1762277962] Versions Suite - 77/77 specs ••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••• SUCCESS! 1.570167ms PASS
[1762277962] Workflows Suite - 27/27 specs ••••••••••••••••••••••••••• SUCCESS! 84.742709ms PASS

Ginkgo ran 5 suites in 1.122107584s
Test Suite Passed

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cbandy
Once this PR has been reviewed and has the lgtm label, please assign vincepri for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @cbandy. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[sbueringer]

/ok-to-test

[cbandy]

Hmm. I don't see the setup-envtest tests in the Prow results. Perhaps because it's a separate module?

[cbandy]

IIUC, this runs make lint but not make test which pulls in tests for setup-envtest:

controller-runtime/Makefile

Lines 71 to 77 in 6724282

	.PHONY: test
	test: test-tools ## Run the script check-everything.sh which will check all.
	TRACE=1 ./hack/check-everything.sh
	.PHONY: test-tools
	test-tools: ## tests the tools codebase (setup-envtest)
	cd tools/setup-envtest && go test ./...

[sbueringer]

You're right. These scripts are a bit of a mess. test-all.sh should be the script that is running in Prow.

Can you try to extend that one to also run the setup-envtest unit tests please? (maybe the regression was already covered by existing tests)

[cbandy]

Can you try to extend that one to also run the setup-envtest unit tests please?

Here or in a separate PR?

(maybe the regression was already covered by existing tests)

The regression was covered, and/but will pass with the changes in this PR.