-
Notifications
You must be signed in to change notification settings - Fork 168
Manually create udev links if udev trigger doesn't work #2216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattcary The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| ) | ||
|
|
||
| const ( | ||
| noMachineType = "none" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change related? Seems like the change for ARM test fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird, that was in a different PR. Let me check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I must have forked off of my arm fix rather than master. Fixed now at any rate.
|
Is there anyway we can test this end to end? |
Yeah, I'm thinking how to do that. I was going to at least run the regular tests and see what happened. |
|
Holding while I see if I can get an e2e test on a node with udev disabled. |
Change-Id: I26bffb3eda447c8343ce39e69c34cf31616120e3
|
@mattcary: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/kind bug
What this PR does / why we need it:
We have seen some cases in the field where
udevadm --triggermay not function correctly, even when disk serial numbers are found. This PR makes sure a proper symlink is created even if udevadm --trigger doesn't work./assign @sunnylovestiramisu