-
Notifications
You must be signed in to change notification settings - Fork 1.6k
KEP-4381: Add pciBusID standard device attribute definition #5669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Welcome @varunrsekar! |
|
Hi @varunrsekar. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a registry of well-known labels, annotations and taints.
Should we put a similar resource attribute registry on the website? Now there are two, it might be a good time to start that registry.
Want the registry to be YAML / KYAML / not-Markdown? That's fine, rendering pages based on machine readable data is a well understood thing for SIG Docs.
Signed-off-by: Varun Ramachandra Sekar <vsekar@nvidia.com>
c30afcb to
5f47fb3
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: varunrsekar The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lmktfy Agreed that we need to have a section in the website docs on this. I already have a PR in the work for that. I'm just waiting on reviews on this KEP PR to complete so that I can keep it aligned with the docs.
resource.kubernetes.io/pciBusID. This attribute may be used to identify devices by their PCI bus address./wg-device-management
/assign @johnbelamaric
/assign @klueska
/assign @pohly
/assign @mortent