Skip to content

Conversation

@nimdrak
Copy link
Contributor

@nimdrak nimdrak commented Oct 29, 2025

Example run

nimdrak@myvm:~/githubs/minikube$ go test -v ./test/integration -run TestISO -tags integration -count 1
Found 4 cores, limiting parallelism with --test.parallel=2
=== RUN   TestISOImage
=== PAUSE TestISOImage
=== CONT  TestISOImage
=== RUN   TestISOImage/Setup
    iso_test.go:46: (dbg) Run:  out/minikube start -p guest-285316 --no-kubernetes 
    iso_test.go:46: (dbg) Done: out/minikube start -p guest-285316 --no-kubernetes : (19.93330073s)
=== RUN   TestISOImage/Binaries
=== RUN   TestISOImage/Binaries/crictl
=== PAUSE TestISOImage/Binaries/crictl
=== RUN   TestISOImage/Binaries/curl
=== PAUSE TestISOImage/Binaries/curl
=== RUN   TestISOImage/Binaries/docker
....
=== RUN   TestISOImage/VersionJSON
    iso_test.go:105: (dbg) Run:  out/minikube -p guest-285316 ssh "cat /version.json"
    iso_test.go:115: Successfully parsed /version.json:
    iso_test.go:117:   iso_version: v1.37.0-1761414747-21797
    iso_test.go:117:   kicbase_version: v0.0.48-1760939008-21773
    iso_test.go:117:   minikube_version: v1.37.0
    iso_test.go:117:   commit: d47086adca11051d3569093b45971860178633b3
...
PASS
Tests completed in 23.013080017s (result code 0)
ok      k8s.io/minikube/test/integration        23.049s

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 29, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @nimdrak. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 29, 2025
@k8s-ci-robot k8s-ci-robot requested review from nirs and prezha October 29, 2025 11:17
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@nimdrak nimdrak changed the title fixes #21815 test: Verify and log iso version in iso_test.go test: Verify and log iso version in iso_test.go Oct 29, 2025
Signed-off-by: Byounguk Lee <nimdrak@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Oct 29, 2025
@medyagh
Copy link
Member

medyagh commented Oct 29, 2025

@nimdrak thanks for this PR, please fix the merge conflict

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 29, 2025
@nirs
Copy link
Contributor

nirs commented Oct 29, 2025

=== RUN TestISOImage/VersionJSON
iso_test.go:105: (dbg) Run: out/minikube -p guest-285316 ssh "cat /version.json"
iso_test.go:115: Successfully parsed /version.json:
iso_test.go:117: iso_version: v1.37.0-1761414747-21797
iso_test.go:117: kicbase_version: v0.0.48-1760939008-21773
iso_test.go:117: minikube_version: v1.37.0
iso_test.go:117: commit: d47086a

@medyagh should we require these keys (or some) and fail the test on missing keys or empty values?

Copy link
Contributor

@nirs nirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nimdrak!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nimdrak, nirs
Once this PR has been reviewed and has the lgtm label, please assign medyagh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 30, 2025
@nimdrak
Copy link
Contributor Author

nimdrak commented Nov 5, 2025

@medyagh Thanks, I rebased it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants