Skip to content

kubeconfig: normalize generated cert paths to forward slashes #21845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

kubeconfig: normalize generated cert paths to forward slashes #21845

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/minikube/kubeconfig/kubeconfig.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,8 +157,8 @@ func configIssues(cfg *api.Config, contextName string, address string) []error {

// populateCerts retains certs already defined in kubeconfig or sets default ones for those missing.
func populateCerts(kcs *Settings, cfg api.Config, contextName string) {
lp := localpath.Profile(contextName)
gp := localpath.MiniPath()
gp := filepath.ToSlash(localpath.MiniPath())
Copy link
Member

@medyagh medyagh Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bobsira I am curious have you explored or investigated that if we can just add filepath.ToSlash to the "localpath" funcs ? would that break anything ?

Copy link
Contributor Author

@bobsira bobsira Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no exlopred this but I believe adding filepath.ToSlash inside the localpath functions would introduce new mixed‑separator paths elsewhere and could re‑break the kubeconfig tests.

lp := filepath.ToSlash(localpath.Profile(contextName))

kcs.CertificateAuthority = path.Join(gp, "ca.crt")
if cluster, ok := cfg.Clusters[contextName]; ok {
Expand Down
Loading