Documenting thirdparty langchain-localai reranker #1282
+34
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikhail Khludnev <mkhl@apache.org>
github-actions
bot
added
langchain
Signed-off-by: Mikhail Khludnev <mkhl@apache.org>
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new LocalAI Reranker documentation page and updates the LocalAI embeddings page title for consistency.
Key changes:
- Created documentation for LocalAI Reranker functionality with installation and usage examples
- Updated the LocalAI embedding page title from "LocalAI" to "LocalAI Embedding" for clarity
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/oss/python/integrations/text_embedding/localai.mdx |
Updated page title to "LocalAI Embedding" for consistency with other embedding integration pages |
src/oss/python/integrations/document_transformers/localai_rerank.mdx |
Added new documentation page for LocalAI Reranker with installation instructions and usage example |
src/oss/python/integrations/document_transformers/localai_rerank.mdx
Outdated
Show resolved
Hide resolved
src/oss/python/integrations/document_transformers/localai_rerank.mdx
Outdated
Show resolved
Hide resolved
…nk.mdx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…nk.mdx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
src/oss/python/integrations/document_transformers/localai_rerank.mdx
Outdated
Show resolved
Hide resolved
src/oss/python/integrations/document_transformers/localai_rerank.mdx
Outdated
Show resolved
Hide resolved
…nk.mdx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…nk.mdx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Comment on lines
+27
to
+30
| openai_api_key=os.environ.get("OPENAI_API_KEY"), | ||
| model="bge-reranker-v2-m3", | ||
| openai_api_base="http://localhost:8080", | ||
| ) |
There was a problem hiding this comment.
The indentation is inconsistent. The arguments in the LocalAIRerank constructor have excessive indentation (8 spaces) which differs from standard Python conventions. Consider using 4 spaces for better consistency with the rest of the codebase.
Suggested change
| openai_api_key=os.environ.get("OPENAI_API_KEY"), | |
| model="bge-reranker-v2-m3", | |
| openai_api_base="http://localhost:8080", | |
| ) | |
| openai_api_key=os.environ.get("OPENAI_API_KEY"), | |
| model="bge-reranker-v2-m3", | |
| openai_api_base="http://localhost:8080", | |
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Documenting thirdparty langchain-localai reranker
Type of change
Type: New documentation page
Related issues/PRs
mkhludnev/langchain-localai#6
Checklist
docs devsrc/docs.jsonif neededAdditional notes