-
Notifications
You must be signed in to change notification settings - Fork 190
Add Sail Support in Guidelines #329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pushpak1300
wants to merge
8
commits into
main
Choose a base branch
from
sail_guidline_support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+214
−190
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a5b53be
Add Sail Support in Guideline
pushpak1300 e0142c7
Fix Markdown
pushpak1300 c4e4e56
Refactor
pushpak1300 4337a77
move method
pushpak1300 5c20313
Merge branch 'main' into sail_guidline_support
pushpak1300 15de371
Merge branch 'main' into sail_guidline_support
pushpak1300 1e09620
rename variables
pushpak1300 3065c86
Refactor GuidelineComposer.php
pushpak1300 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,7 @@ | ||
| @php | ||
| /** @var \Laravel\Boost\Install\GuidelineAssist $assist */ | ||
| @endphp | ||
| ## Test Enforcement | ||
|
|
||
| - Every change must be programmatically tested. Write a new test or update an existing test, then run the affected tests to make sure they pass. | ||
| - Run the minimum number of tests needed to ensure code quality and speed. Use `php artisan test` with a specific filename or filter. | ||
| - Run the minimum number of tests needed to ensure code quality and speed. Use `{{ $assist->artisan() }} test` with a specific filename or filter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,7 @@ | ||
| @php | ||
| /** @var \Laravel\Boost\Install\GuidelineAssist $assist */ | ||
| @endphp | ||
| ## Laravel Pint Code Formatter | ||
|
|
||
| - You must run `vendor/bin/pint --dirty` before finalizing changes to ensure your code matches the project's expected style. | ||
| - Do not run `vendor/bin/pint --test`, simply run `vendor/bin/pint` to fix any formatting issues. | ||
| - You must run `{{ $assist->bin() }}pint --dirty` before finalizing changes to ensure your code matches the project's expected style. | ||
| - Do not run `{{ $assist->bin() }}pint --test`, simply run `{{ $assist->bin() }}pint` to fix any formatting issues. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| ## Laravel Sail | ||
|
|
||
| - This project runs inside Laravel Sail's Docker containers. You MUST execute all commands through Sail. | ||
| - Start services using `vendor/bin/sail up -d` and stop them with `vendor/bin/sail stop`. | ||
| - Open the application in the browser by running `vendor/bin/sail open`. | ||
| - Always prefix PHP, Artisan, Composer, and Node commands** with `vendor/bin/sail`. Examples: | ||
| - Run migrations: `vendor/bin/sail artisan migrate` | ||
| - Install Composer packages: `vendor/bin/sail composer install` | ||
| - Run npm: `vendor/bin/sail npm run dev` | ||
| - Execute PHP scripts: `vendor/bin/sail php [script]` | ||
| - View all available Sail commands by running `vendor/bin/sail` without arguments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typically, I feel like this would be written as
{{ $assist->bin() }}/pint --dirty, so that$assist->bin()would return the path without the trailing slash for clarity. Thoughts?