Skip to content

alpine: support --plain mode #3057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

alpine: support --plain mode #3057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 ...a.TEMPLATE.d/boot/00-alpine-user-group.sh → ....d/boot.essential/00-alpine-user-group.sh
View file
Open in desktop
File renamed without changes.
0 ....TEMPLATE.d/boot/01-alpine-ash-as-bash.sh → ...d/boot.essential/01-alpine-ash-as-bash.sh
View file
Open in desktop
File renamed without changes.
0 .../cidata.TEMPLATE.d/boot/10-alpine-prep.sh → ...MPLATE.d/boot.essential/10-alpine-prep.sh
View file
Open in desktop
File renamed without changes.
11 changes: 10 additions & 1 deletion pkg/cidata/cidata.TEMPLATE.d/boot.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,17 @@ CODE=0
# has run because it might move the directories to /mnt/data on first boot. In that
# case changes made on restart would be lost.

# The boot.essential scripts are executed in plain mode too.
for f in "${LIMA_CIDATA_MNT}"/boot.essential/*.sh; do
INFO "Executing $f"
if ! "$f"; then
WARNING "Failed to execute $f"
CODE=1
fi
done

if [ "$LIMA_CIDATA_PLAIN" = "1" ]; then
INFO "Plain mode. Skipping to run boot scripts. Provisioning scripts will be still executed. Guest agent will not be running."
INFO "Plain mode. Skipping to run non-essential boot scripts. Provisioning scripts will be still executed. Guest agent will not be running."
else
for f in "${LIMA_CIDATA_MNT}"/boot/*; do
INFO "Executing $f"
Expand Down
3 changes: 3 additions & 0 deletions pkg/cidata/cidata.TEMPLATE.d/boot/DO_NOT_ADD_MORE_SCRIPTS.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
The "essential" scripts are limited to scripts that are essential even in the "plain" mode (`limactl create --plain`).

Do not add more scripts to this `boot.essential` directory, unless they are really essential.
1 change: 1 addition & 0 deletions website/content/en/docs/dev/internals.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ See [Building Ansible inventories](https://docs.ansible.com/ansible/latest/inven
- `lima-guestagent`: Lima guest agent binary
- `nerdctl-full.tgz`: [`nerdctl-full-<VERSION>-<OS>-<ARCH>.tar.gz`](https://github.com/containerd/nerdctl/releases)
- `boot.sh`: Boot script
- `boot.essential/*`: Boot script modules (executed in "plain" mode too)
- `boot/*`: Boot script modules
- `util/*`: Utility command scripts, executed in the boot script modules
- `provision.system/*`: Custom provision scripts (system)
Expand Down
Loading