Skip to content

[NFC][CodeGen][CFI] Pre-commit transparent_union tests #158192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 13, 2025
Merged

[NFC][CodeGen][CFI] Pre-commit transparent_union tests #158192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
650ff78
[𝘀𝗽𝗿] changes to main this commit is based on
vitalybuka Sep 12, 2025
1894ea2
[𝘀𝗽𝗿] initial version
vitalybuka Sep 12, 2025
b5e073c
[𝘀𝗽𝗿] changes introduced through rebase
vitalybuka Sep 12, 2025
6c1edf4
newline
vitalybuka Sep 12, 2025
dcad507
[𝘀𝗽𝗿] changes introduced through rebase
vitalybuka Sep 12, 2025
2cb2ff8
rebase
vitalybuka Sep 12, 2025
ad7bdb7
spaces
vitalybuka Sep 12, 2025
4c3ee31
TYPE4
vitalybuka Sep 12, 2025
1e4e7a5
[𝘀𝗽𝗿] changes introduced through rebase
vitalybuka Sep 13, 2025
976953c
rebase
vitalybuka Sep 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions clang/test/CodeGen/cfi-icall-generalize.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,21 @@ void g(int** (*fp)(const char *, const char **)) {
fp(0, 0);
}

union Union {
char *c;
long *n;
} __attribute__((transparent_union));

// CHECK: define{{.*}} void @uni({{.*}} !type [[TYPE2:![0-9]+]] !type [[TYPE2_GENERALIZED:![0-9]+]]
void uni(void (*fn)(union Union), union Union arg1) {
// UNGENERALIZED: call i1 @llvm.type.test(ptr {{.*}}, metadata !"_ZTSFv5UnionE")
// GENERALIZED: call i1 @llvm.type.test(ptr {{.*}}, metadata !"_ZTSFv5UnionE.generalized")
fn(arg1);
}

// CHECK: [[TYPE]] = !{i64 0, !"_ZTSFPPiPKcPS2_E"}
// CHECK: [[TYPE_GENERALIZED]] = !{i64 0, !"_ZTSFPvPKvS_E.generalized"}

// CHECK: [[TYPE2]] = !{i64 0, !"_ZTSFvPFv5UnionES_E"}
// CHECK: [[TYPE2_GENERALIZED]] = !{i64 0, !"_ZTSFvPv5UnionE.generalized"}

14 changes: 14 additions & 0 deletions clang/test/CodeGen/cfi-icall-normalize2.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,20 @@ void baz(void (*fn)(int, int, int), int arg1, int arg2, int arg3) {
fn(arg1, arg2, arg3);
}

union Union {
char *c;
long *n;
} __attribute__((transparent_union));

void uni(void (*fn)(union Union), union Union arg1) {
// CHECK-LABEL: define{{.*}}uni
// CHECK-SAME: {{.*}}!type ![[TYPE4:[0-9]+]] !type !{{[0-9]+}}
// CHECK: call i1 @llvm.type.test({{i8\*|ptr}} {{%f|%0}}, metadata !"_ZTSFv5UnionE.normalized")
fn(arg1);
}

// CHECK: ![[TYPE1]] = !{i64 0, !"_ZTSFvPFvu3i32ES_E.normalized"}
// CHECK: ![[TYPE2]] = !{i64 0, !"_ZTSFvPFvu3i32S_ES_S_E.normalized"}
// CHECK: ![[TYPE3]] = !{i64 0, !"_ZTSFvPFvu3i32S_S_ES_S_S_E.normalized"}
// CHECK: ![[TYPE4]] = !{i64 0, !"_ZTSFvPFv5UnionES_E.normalized"}

16 changes: 16 additions & 0 deletions clang/test/CodeGen/kcfi-generalize.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,24 @@ void g(int** (*fp)(const char *, const char **)) {
fp(0, 0);
}

union Union {
char *c;
long *n;
} __attribute__((transparent_union));

// CHECK: define{{.*}} void @uni({{.*}} !kcfi_type [[TYPE4:![0-9]+]]
void uni(void (*fn)(union Union), union Union arg1) {
// UNGENERALIZED: call {{.*}} [ "kcfi"(i32 -1037059548) ]
// GENERALIZED: call {{.*}} [ "kcfi"(i32 422130955) ]
fn(arg1);
}

// UNGENERALIZED: [[TYPE]] = !{i32 1296635908}
// GENERALIZED: [[TYPE]] = !{i32 -49168686}

// UNGENERALIZED: [[TYPE3]] = !{i32 874141567}
// GENERALIZED: [[TYPE3]] = !{i32 954385378}

// UNGENERALIZED: [[TYPE4]] = !{i32 981319178}
// GENERALIZED: [[TYPE4]] = !{i32 -1599950473}

14 changes: 14 additions & 0 deletions clang/test/CodeGen/kcfi-normalize.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,21 @@ void baz(void (*fn)(int, int, int), int arg1, int arg2, int arg3) {
fn(arg1, arg2, arg3);
}

union Union {
char *c;
long *n;
} __attribute__((transparent_union));

void uni(void (*fn)(union Union), union Union arg1) {
// CHECK-LABEL: define{{.*}}uni
// CHECK-SAME: {{.*}}!kcfi_type ![[TYPE4:[0-9]+]]
// CHECK: call void %0(ptr %1) [ "kcfi"(i32 -1430221633) ]
fn(arg1);
}

// CHECK: ![[#]] = !{i32 4, !"cfi-normalize-integers", i32 1}
// CHECK: ![[TYPE1]] = !{i32 -1143117868}
// CHECK: ![[TYPE2]] = !{i32 -460921415}
// CHECK: ![[TYPE3]] = !{i32 -333839615}
// CHECK: ![[TYPE4]] = !{i32 1766237188}

Loading