[ORC][LibraryResolver] Fix ensureFilterBuilt assertion failure and concurrency issue. #166510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chitecture compatibility check
vgvassilev
reviewed
Nov 5, 2025
Comment on lines
214
to
215
| std::vector<std::shared_ptr<LibraryInfo>> getLibraries(LibState S, | ||
| PathType K) const { |
Contributor
There was a problem hiding this comment.
Suggested change
| std::vector<std::shared_ptr<LibraryInfo>> getLibraries(LibState S, | |
| PathType K) const { | |
| void getLibraries(LibState S, PathType K, std::vector<std::shared_ptr<LibraryInfo>>& Outs) const { |
Why this became a shared_ptr? Are we going to lose performance?
Contributor
Author
There was a problem hiding this comment.
It was already StringMap<std::shared_ptr<LibraryInfo>> Libraries; in LibraryManager.
Would using raw pointers or references be safe in a concurrent environment?
Contributor
There was a problem hiding this comment.
Let’s keep the stared_ptr like this and measure the performance on the downstream client.
vgvassilev
approved these changes
Nov 5, 2025
Contributor
vgvassilev
left a comment
vgvassilev
left a comment
There was a problem hiding this comment.
LGTM! Should we land this together with enabling the tests from #166147
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed architecture compatibility check.
Previously, we used
sys::getDefaultTriple(), which caused issues on build botsusing cross-compilation. We now ensure that the target architecture where the
shared library (.so) is run or loaded matches the architecture it was built for.
Fixed ensureFilterBuilt assertion failure.
Replaced use of FilteredView with a safer alternative for concurrent environments.
The old FilteredView approach iterated over shared state without sufficient
synchronization, which could lead to invalid accesses when libraries were being
added or removed concurrently.