feat:optimize gllayer checkFeaturesVisibleChange performance #2684
+30
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuzhenn
requested changes
Nov 10, 2025
| continue; | ||
| } | ||
| if (!Array.isArray(feats)) { | ||
| feats = [feats]; |
Member
There was a problem hiding this comment.
这里会创建新的array对象，建议在循环外创建一个临时array，每次用 array[0] = feats; 赋值，以减少创建的临时数组对象数量
| super(...args); | ||
| this.features = {}; | ||
| //使用array结构,更好的遍历的性能,遍历时注意null和空洞的情况 | ||
| this.features = []; |
Member
There was a problem hiding this comment.
有个潜在的问题，geometry的uid生成是全局性，而且全局不会重复。
如果存在多个点线面图层：
- 第一个图层的uid会从0开始，uid 等于所有图层中 geometries 数量
- 后续图层的uid都不从0开始
- 因为uid不从0开始，后续图层的features数组开头会存在undefined对象
- 如果某个图层新增了Geometry，因为uid是全局的，新Geometry的uid可能比当前features中最大的uid要大很多，新增Geometry和前一个Geometry之间会产生大量的undefined对象
我感觉可以这么改进：
- this.features改回{}
- checkVisible 逻辑改为遍历 Object.values(this.features)
- 如果 Object.values 存在性能瓶颈，可以把values缓存为属性，新增一个 this.featureValues = Object.values(this.features)
- 每次this.features发生变化时，也更新 this.featureValues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.