Skip to content

Conversation

@jaideepkathiresan
Copy link

This PR addresses Issue #316

Summary of Changes

  1. Migrated all configuration from setup.cfg into pyproject.toml
  2. Removed setup.cfg
  3. Preserved all project metadata
  4. Organized developer dependencies using PEP 735 dependency groups

@samcunliffe samcunliffe added New feature New feature or request Maintenance Not related to the development of new features labels Oct 31, 2025
Copy link
Collaborator

@samcunliffe samcunliffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your first contribution, @jaideepkathiresan! 👋

I'm pretty confident we need to tweak the tox.ini to get tox to run the correct thing (dependency groups), then remove the old style [project.optional-dependencies].

Thanks for the work so far, sorry for the slight scope-drift. It's a bit of a bigger task than I first thought. Absolutely no worries if you don't have the capacity for this, just let us know and one of us will pick it up!

@jaideepkathiresan
Copy link
Author

Hi @samcunliffe, thanks you so much for the feedback! Yeah, I guess for the current scope, you could assign someone else, I am also kind of occupied with something.
Thank-you so much @samcunliffe for reviewing, happy to have contributed the initial PR!

@samcunliffe samcunliffe requested a review from dstansby November 4, 2025 08:04
Copy link
Collaborator

@samcunliffe samcunliffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dstansby

As written, this solves the ticket. And I've pushed some commits to @jaideepkathiresan's branch so I probably shouldn't approve myself.

Follow up thoughts:

  • We might want to merge tox.ini into pyproject.toml and also use tox-uv in the workflow (it's not too bad: rough proof of concept).
  • We might want to drop tox entirely from our tools.
  • We might want to switch to uv in the actions workflows and elsewhere.

@samcunliffe samcunliffe dismissed their stale review November 4, 2025 08:07

Fixed, but not approving myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintenance Not related to the development of new features New feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants