Skip to content

Conversation

@razvanphp
Copy link
Contributor

@razvanphp razvanphp commented Oct 23, 2025

Should I add unit tests for those? TBH, those are just for the OCTT test cases to pass... so probably not.

fixes #327

Copy link
Owner

@matth-x matth-x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@razvanphp Thanks again for the fixes (and for updating the CI)! Only one question, then this is good to go


#if MO_ENABLE_LOCAL_AUTH
if (authorizationService) {
if (authorizationService && authorizationService->localAuthListEnabled()) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This affects the SupportedFeatureProfiles Configuration key. In my understanding, that key tells the server what the charger is in theory capable of. When the the server disables unused profiles, then the charger would still be able to support them, in theory.

Did this change come out of an OCTT test case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, when disabled, the OCTT expects it not to appear in the list anymore (as it is not supported). This avoids having another precompiled firmware just to pass those tests...

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@razvanphp
Copy link
Contributor Author

...and for updating the CI

BTW, the memory heap calculation misses some ENV variables I think, I can't fix that one. Do you still have access to those servers or should we look into another cloud-native solution?

@matth-x
Copy link
Owner

matth-x commented Nov 10, 2025

BTW, the memory heap calculation misses some ENV variables I think, I can't fix that one. Do you still have access to those servers or should we look into another cloud-native solution?

Thanks for looking into this too!

The motivation to use a self-hosted CICD server was because the OCTT expected the SUT to expose endpoints on the internet. However they added a new connection method so that the SUT can just create another WebSocket connection to the server, alongside the OCPP connection. So the heap measurement pipeline can fully run on the GitHub Actions servers again and the self-hosted server can be removed. Already worked on something, just need to make it available on main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to make specific feature not support

2 participants