Skip to content

Fix double execution of meteor properties functions #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix double execution of meteor properties functions #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,14 +287,24 @@ export default {
set(this.$data.$meteor.data, key, result)
}

// Vue autorun
const unwatch = this.$watch(func, noop)
const watcher = this._watchers.find(w => w.getter === func)
let unwatch, watcher

// Meteor autorun
let computation = this.$autorun(() => {
// Vue watcher deps are also-rebuilt
const result = watcher.get()
const computation = this.$autorun((_computation) => {
let result

if (_computation.firstRun) {
// Initialize Vue Watcher, func will be executed by this.$watch().
// It is important to place it here so the Tracker computation can
// be initialized with the same function execution.
unwatch = this.$watch(func, noop)
watcher = this._watchers.find(w => w.getter === func)
result = watcher.value
} else {
result = watcher.get()
}

// Vue watcher deps are also rebuilt
setResult(result)
})
const unautorun = () => {
Expand Down