Skip to content

Set Additional Reporting Currency demo data for financial reporting #28760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Set Additional Reporting Currency demo data for financial reporting #28760

wants to merge 7 commits into from

Conversation

@tuan-nguyen-fenwick
Copy link

@tuan-nguyen-fenwick tuan-nguyen-fenwick commented Jun 11, 2025 •
edited by github-actions bot
Loading

Summary

  • Applies to the W1 Contoso Coffee Demo Data app.
  • Set Additional Reporting Currency on General Ledger Setup.
  • Added new residual FX gains and losses G/L accounts. These G/L accounts are not specific to any country and required to allow posting with additional reporting currency.

Work Item(s)

Fixes #28759
Fixes: AB#575835

@tuan-nguyen-fenwick tuan-nguyen-fenwick requested a review from a team as a code owner June 11, 2025 05:11
@JesperSchulz JesperSchulz added approved The issue is approved Finance GitHub request for Finance area and removed approved The issue is approved labels Jun 12, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 12, 2025

This issue has been approved for contribution ✅ Thanks for contributing.

@JesperSchulz JesperSchulz self-assigned this Jun 23, 2025
@JesperSchulz
Copy link
Contributor

JesperSchulz commented Jun 23, 2025

@tuan-nguyen-fenwick, please address the CI build issues. Once build passes, we can move on to the next step!

@github-actions github-actions bot added the linked Issue is linked to a Azure Boards work item label Jun 26, 2025
@tuan-nguyen-fenwick
Copy link
Author

tuan-nguyen-fenwick commented Jun 26, 2025

@tuan-nguyen-fenwick, please address the CI build issues. Once build passes, we can move on to the next step!

@JesperSchulz Thanks, I have addressed the build issues.

@JesperSchulz JesperSchulz added the processing-PR The PR is currently being reviewed label Jul 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2025

Processing this PR. The branch is now locked 🔒 Please don't push updates unless otherwise agreed.

@JesperSchulz
Copy link
Contributor

JesperSchulz commented Jul 8, 2025

Merged recent changes. Will ask for new review.

@AleksanderGladkov AleksanderGladkov added Integration GitHub request for Integration area and removed Finance GitHub request for Finance area labels Aug 7, 2025
@tuan-nguyen-fenwick
Copy link
Author

tuan-nguyen-fenwick commented Aug 18, 2025

Hi @elbardel @JesperSchulz, could you review this PR please?

@tuan-nguyen-fenwick
Copy link
Author

tuan-nguyen-fenwick commented Aug 22, 2025

@WaelAbuSeada I have addressed the error causing in MX. The G/L account numbers seem to be conflicting. Please see the latest commit.

@JesperSchulz JesperSchulz removed their assignment Sep 2, 2025
WaelAbuSeada
WaelAbuSeada requested changes Sep 3, 2025
View reviewed changes
...oCoffeeDemoDataset/app/DemoData/Finance/2.Master data/CreateAddReportingCurrency.Codeunit.al
GLAccountCategory: Record "G/L Account Category";
SubCategory: Text[80];
begin
ContosoGLAccount.AddAccountForLocalization(ResidualFXGainsName(), '9335');
Copy link
Member

@WaelAbuSeada WaelAbuSeada Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GL account introduced in W1 need to be localized in all countries

AndreasHans added a commit that referenced this pull request Sep 24, 2025
@AndreasHans
Squashed PR #28760 from ALAppExtensions
fd1a166
AndreasHans added a commit that referenced this pull request Sep 24, 2025
@AndreasHans
Squashed PR #28760 from ALAppExtensions
cec936a
AndreasHans added a commit that referenced this pull request Sep 24, 2025
@AndreasHans
Squashed PR #28760 from ALAppExtensions
ae35238
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WaelAbuSeada WaelAbuSeada WaelAbuSeada requested changes

@elbardel elbardel Awaiting requested review from elbardel elbardel is a code owner automatically assigned from microsoft/dynamics-365-business-central

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

Integration GitHub request for Integration area linked Issue is linked to a Azure Boards work item processing-PR The PR is currently being reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Set Additional Reporting Currency demo data for financial reporting

4 participants

@tuan-nguyen-fenwick @JesperSchulz @WaelAbuSeada @AleksanderGladkov