-
Notifications
You must be signed in to change notification settings - Fork 7.5k
[UI Tests] Peek - fix UI tests via setting hotkeys back to Ctrl+Space combo for tests only #43168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@lei9444 all tests pass finally: https://microsoft.visualstudio.com/Dart/_build/results?buildId=133161329&view=results |
| var enabledModules = new Dictionary<string, bool>(); | ||
| foreach (var module in property.Value.EnumerateObject()) | ||
| { | ||
| // Set module to true if in modulesToEnable array, otherwise false |
Check failure
Code scanning / check-spelling
Forbidden Pattern Error
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.
See ❌ Event descriptions for more information. These words are not needed and should be removedcabstr CIBUILD djwsxzxb icf installscopeperuser ksa registryroot regroot rtm suntimes TARGETDIR utmForbidden patterns 🙅 (1)In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves. These forbidden patterns matched content: Should be
|
|
I've broke it again |
This pull request introduces a static initialization step to the
PeekFilePreviewTestsclass to ensure the correct test settings are present before tests run. The main change is the addition of a static constructor that creates or updates thesettings.jsonfile with predefined settings, including setting the activation shortcut to Ctrl+Space.Test setup improvements:
PeekFilePreviewTeststhat calls a newFixSettingsFileBeforeTestsmethod, ensuring the necessary settings file exists and is properly configured before any tests execute.FixSettingsFileBeforeTeststo create the required directory and write asettings.jsonfile with specific test configuration, including setting the activation shortcut to Ctrl+Space and other test-relevant properties.