Skip to content

Conversation

@jakebailey
Copy link
Member

Pulling in the latest since a bunch changed.

Copilot AI review requested due to automatic review settings November 7, 2025 05:52
@github-project-automation github-project-automation bot moved this to Not started in PR Backlog Nov 7, 2025
@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Nov 7, 2025
@jakebailey
Copy link
Member Author

@typescript-bot user test this
@typescript-bot run dt
@typescript-bot test top800

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 7, 2025

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
user test this ✅ Started ✅ Results
run dt ✅ Started 👀 Results
test top800 ✅ Started 👀 Results

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates test baseline files that capture expected compiler output. The changes reflect updates to performance metrics and type information that the TypeScript compiler generates.

  • Updates Symbol count threshold from 50,000 to 100,000 in JSX test baselines
  • Adds "oncommand" to the globalThis type union and adjusts line numbers accordingly

Reviewed Changes

Copilot reviewed 2 out of 6 changed files in this pull request and generated no comments.

File Description
tests/baselines/reference/jsxIntrinsicElementsCompatability.types Updates expected Symbol count metric from 50,000 to 100,000
tests/baselines/reference/globalThisBlockscopedProperties.types Adds "oncommand" event handler to the globalThis type union and adjusts line numbers

@typescript-bot
Copy link
Collaborator

Hey @jakebailey, the results of running the DT tests are ready.

There were interesting changes:

Branch only errors:

Package: serviceworker-webpack-plugin
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/serviceworker-webpack-plugin/serviceworker-webpack-plugin-tests.ts
  49:22  error  TypeScript@local compile error: 
Property 'pushManager' does not exist on type 'ServiceWorkerRegistration'  @definitelytyped/expect
  53:22  error  TypeScript@local compile error: 
Property 'pushManager' does not exist on type 'ServiceWorkerRegistration'  @definitelytyped/expect

✖ 2 problems (2 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251106/node_modules/@definitelytyped/dtslint/dist/index.js:199:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.34_typescript@6.0.0-dev.20251106/node_modules/@definitelytyped/dtslint/dist/index.js:191:20)

You can check the log here.

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/62730/merge:

There were infrastructure failures potentially unrelated to your change:

  • 1 instance of "Git clone failed"

Otherwise...

Everything looks good!

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the top 800 repos with tsc comparing main and refs/pull/62730/merge:

Something interesting changed - please have a look.

Details

microsoft/azuredatastudio

44 of 67 projects failed to build with the old tsc and were ignored

extensions/vscode-test-resolver/tsconfig.json

microsoft/vscode

13 of 63 projects failed to build with the old tsc and were ignored

src/tsconfig.tsec.json

src/tsconfig.monaco.json

extensions/vscode-test-resolver/tsconfig.json

build/checker/tsconfig.electron-browser.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

Status: Not started

Development

Successfully merging this pull request may close these issues.

2 participants