Skip to content

Adding the test cases which are skipped due to EPIPE error #1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Adding the test cases which are skipped due to EPIPE error #1115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
99b62c8
unskipping the test cases
Deekshitha2812 Oct 22, 2025
4b6ad93
error handling for EPIPE
Deekshitha2812 Oct 24, 2025
904a286
error handling for EPIPE
Deekshitha2812 Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion node/test/toolrunnerTestsWithExecAsync.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -951,7 +951,7 @@ describe('Toolrunner Tests With ExecAsync', function () {
})
}
})
it.skip('Exec pipe output to file and another tool, fails if second tool fails', function (done) {
it('Exec pipe output to file and another tool, fails if second tool fails', function (done) {
this.timeout(20000);

var _testExecOptions = <trm.IExecOptions>{
Expand Down
2 changes: 1 addition & 1 deletion node/test/toolrunnertests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1101,7 +1101,7 @@ describe('Toolrunner Tests', function () {
})
}
})
it.skip('Exec pipe output to file and another tool, fails if second tool fails', function (done) {
it('Exec pipe output to file and another tool, fails if second tool fails', function (done) {
this.timeout(20000);

var _testExecOptions = <trm.IExecOptions>{
Expand Down
20 changes: 18 additions & 2 deletions node/toolrunner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,13 +671,20 @@ export class ToolRunner extends events.EventEmitter {
});
}

let stdinEpipe = false;
cp.stdin?.on("error", (err: Error) => {
if (!im.isSigPipeError(err)) {
throw err;
}
stdinEpipe = true;
});
//pipe stdout of first tool to stdin of second tool
cpFirst.stdout?.on('data', (data: Buffer) => {
try {
if (fileStream) {
fileStream.write(data);
}
if (!cp.stdin?.destroyed) {
if (!cp.stdin?.destroyed && !cp.stdin?.writableEnded && !stdinEpipe) {
cp.stdin?.write(data);
}
} catch (err) {
Expand Down Expand Up @@ -871,13 +878,22 @@ export class ToolRunner extends events.EventEmitter {
});
}

let stdinEpipe = false;
cp.stdin?.on("error", (err: Error) => {
if (!im.isSigPipeError(err)) {
throw err;
}
stdinEpipe = true;
});
//pipe stdout of first tool to stdin of second tool
cpFirst.stdout?.on('data', (data: Buffer) => {
try {
if (fileStream) {
fileStream.write(data);
}
cp.stdin?.write(data);
if (!cp.stdin?.destroyed && !cp.stdin?.writableEnded && !stdinEpipe) {
cp.stdin?.write(data);
}
} catch (err) {
this._debug('Failed to pipe output of ' + toolPathFirst + ' to ' + toolPath);
this._debug(toolPath + ' might have exited due to errors prematurely. Verify the arguments passed are valid.');
Expand Down