FIX: S360 Resolve [CodeQL.SM02986] 'Cast from char* to wchar_t* #309
+13
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds suppression comments for CodeQL static analysis warnings (SM02986) related to reinterpret_cast operations when converting raw byte buffers to wide character types (SQLWCHAR* and wchar_t*) in the LOB data fetching function.
Key changes:
- Added inline comments justifying the safety of three
reinterpret_castoperations - Comments explain alignment guarantees from
std::vectorand ODBC driver behavior
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📊 Code Coverage Report
Diff CoverageDiff: main...HEAD, staged and unstaged changes
Summary
📋 Files Needing Attention📉 Files with overall lowest coverage (click to expand)mssql_python.pybind.ddbc_bindings.cpp: 70.9%
mssql_python.pybind.connection.connection_pool.cpp: 78.9%
mssql_python.ddbc_bindings.py: 79.6%
mssql_python.pybind.connection.connection.cpp: 81.2%
mssql_python.connection.py: 82.9%
mssql_python.auth.py: 87.1%
mssql_python.pooling.py: 87.7%
mssql_python.helpers.py: 88.9%
mssql_python.__init__.py: 90.7%
mssql_python.exceptions.py: 92.1%🔗 Quick Links
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
bewithgaurav
approved these changes
Nov 4, 2025
| if (isWideChar) { | ||
| #if defined(_WIN32) | ||
| std::wstring wstr(reinterpret_cast<const wchar_t*>(buffer.data()), buffer.size() / sizeof(wchar_t)); | ||
| size_t wcharCount = buffer.size() / sizeof(wchar_t); |
There was a problem hiding this comment.
can we add some comments around the changes? also, can add a pointer referencing a small description of the s360 issue.
sumitmsft
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work Item / Issue Reference
Summary
This pull request adds explanatory comments to several
reinterpret_caststatements in theFetchLobColumnDatafunction withinmssql_python/pybind/ddbc_bindings.cpp, clarifying the safety of these casts for CodeQL static analysis. The comments explain why casting fromstd::vectordata to wide character pointers is safe in this context.Code safety and documentation improvements:
reinterpret_cast<const SQLWCHAR*>(chunk.data())and similar casts, explaining alignment guarantees and safe usage for CodeQL [SM02986] in both Windows and Linux/macOS code paths. [1] [2]