Skip to content

Apply clangd IWYU export pragmas to transitive includes #1492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Apply clangd IWYU export pragmas to transitive includes #1492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
565895f
Apply clangd IWYU export pragmas to transitive includes
eramongodb Oct 28, 2025
3a00ba4
Address clangd IWYU missing-includes warnings
eramongodb Oct 28, 2025
8ae2860
Merge remote-tracking branch 'upstream/master' into cxx-clangd-iwyu
eramongodb Oct 28, 2025
c1edf24
Remove unnecessary include directive separator
eramongodb Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/bsoncxx/include/bsoncxx/v1/array/value.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,18 @@

#pragma once

#include <bsoncxx/v1/array/value-fwd.hpp>
#include <bsoncxx/v1/array/value-fwd.hpp> // IWYU pragma: export

//

#include <bsoncxx/v1/detail/prelude.hpp>

#include <bsoncxx/v1/array/view.hpp>
#include <bsoncxx/v1/array/view.hpp> // IWYU pragma: export
#include <bsoncxx/v1/config/export.hpp>
#include <bsoncxx/v1/document/value.hpp>
#include <bsoncxx/v1/detail/type_traits.hpp>
#include <bsoncxx/v1/document/value.hpp> // IWYU pragma: export

#include <cstddef>
#include <cstdint>
#include <type_traits>
#include <utility>
Expand Down
6 changes: 3 additions & 3 deletions src/bsoncxx/include/bsoncxx/v1/array/view.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,15 @@

#pragma once

#include <bsoncxx/v1/array/view-fwd.hpp>
#include <bsoncxx/v1/array/view-fwd.hpp> // IWYU pragma: export

//

#include <bsoncxx/v1/detail/prelude.hpp>

#include <bsoncxx/v1/config/export.hpp>
#include <bsoncxx/v1/document/view.hpp>
#include <bsoncxx/v1/element/view.hpp>
#include <bsoncxx/v1/document/view.hpp> // IWYU pragma: export
#include <bsoncxx/v1/element/view.hpp> // IWYU pragma: export

#include <cstddef>
#include <cstdint>
Expand Down
3 changes: 2 additions & 1 deletion src/bsoncxx/include/bsoncxx/v1/decimal128.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

#pragma once

#include <bsoncxx/v1/decimal128-fwd.hpp>
#include <bsoncxx/v1/decimal128-fwd.hpp> // IWYU pragma: export

//

Expand All @@ -24,6 +24,7 @@
#include <bsoncxx/v1/stdx/string_view.hpp>

#include <cstdint>
#include <string>
#include <system_error>
#include <type_traits>

Expand Down
4 changes: 3 additions & 1 deletion src/bsoncxx/include/bsoncxx/v1/detail/bit.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,10 @@

#if defined(__has_include)
#if __has_include(<bit>) && (!defined(_MSVC_LANG) || _MSVC_LANG >= 202002L)

// Prioritize using std::endian from C++20.
#include <bit>
#include <bit> // IWYU pragma: export

#endif // __has_include(<bit>) && (!defined(_MSVC_LANG) || _MSVC_LANG >= 202002L)
#elif defined(_WIN32)
// Forward-compatibility with STL: https://github.com/microsoft/STL/blob/vs-2019-16.5/stl/inc/bit#L26
Expand Down
1 change: 1 addition & 0 deletions src/bsoncxx/include/bsoncxx/v1/detail/compare.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
#include <cstddef>
#include <functional>
#include <type_traits>
#include <utility>

namespace bsoncxx {
namespace detail {
Expand Down
2 changes: 1 addition & 1 deletion src/bsoncxx/include/bsoncxx/v1/detail/type_traits.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

#include <bsoncxx/v1/detail/macros.hpp>

#include <type_traits>
#include <type_traits> // IWYU pragma: export
#include <utility>

namespace bsoncxx {
Expand Down
8 changes: 5 additions & 3 deletions src/bsoncxx/include/bsoncxx/v1/document/value.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,20 @@

#pragma once

#include <bsoncxx/v1/document/value-fwd.hpp>
#include <bsoncxx/v1/document/value-fwd.hpp> // IWYU pragma: export

//

#include <bsoncxx/v1/detail/prelude.hpp>

#include <bsoncxx/v1/config/export.hpp>
#include <bsoncxx/v1/detail/type_traits.hpp>
#include <bsoncxx/v1/document/view.hpp>
#include <bsoncxx/v1/element/view.hpp>
#include <bsoncxx/v1/document/view.hpp> // IWYU pragma: export
#include <bsoncxx/v1/element/view.hpp> // IWYU pragma: export
#include <bsoncxx/v1/stdx/string_view.hpp>

#include <cstddef>
#include <cstdint>
#include <cstring>
#include <functional>
#include <memory>
Expand Down
4 changes: 2 additions & 2 deletions src/bsoncxx/include/bsoncxx/v1/document/view.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,15 @@

#pragma once

#include <bsoncxx/v1/document/view-fwd.hpp>
#include <bsoncxx/v1/document/view-fwd.hpp> // IWYU pragma: export

//

#include <bsoncxx/v1/detail/prelude.hpp>

#include <bsoncxx/v1/config/export.hpp>
#include <bsoncxx/v1/detail/bit.hpp>
#include <bsoncxx/v1/element/view.hpp>
#include <bsoncxx/v1/element/view.hpp> // IWYU pragma: export
#include <bsoncxx/v1/stdx/string_view.hpp>

#include <cstddef>
Expand Down
2 changes: 1 addition & 1 deletion src/bsoncxx/include/bsoncxx/v1/element/view.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

#pragma once

#include <bsoncxx/v1/element/view-fwd.hpp>
#include <bsoncxx/v1/element/view-fwd.hpp> // IWYU pragma: export

//

Expand Down
2 changes: 1 addition & 1 deletion src/bsoncxx/include/bsoncxx/v1/exception.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

#pragma once

#include <bsoncxx/v1/exception-fwd.hpp>
#include <bsoncxx/v1/exception-fwd.hpp> // IWYU pragma: export

//

Expand Down
2 changes: 1 addition & 1 deletion src/bsoncxx/include/bsoncxx/v1/oid.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

#pragma once

#include <bsoncxx/v1/oid-fwd.hpp>
#include <bsoncxx/v1/oid-fwd.hpp> // IWYU pragma: export

//

Expand Down
1 change: 1 addition & 0 deletions src/bsoncxx/include/bsoncxx/v1/stdx/optional.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ using std::optional;
#include <cstddef>
#include <cstdio>
#include <exception>
#include <functional>
#include <initializer_list>
#include <memory>
#include <new>
Expand Down
3 changes: 3 additions & 0 deletions src/bsoncxx/include/bsoncxx/v1/stdx/string_view.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,11 @@ using std::string_view;

#include <algorithm>
#include <cstddef>
#include <functional>
#include <ios>
#include <iterator>
#include <limits>
#include <ostream>
#include <stdexcept>
#include <string>
#include <utility>
Expand Down
3 changes: 2 additions & 1 deletion src/bsoncxx/include/bsoncxx/v1/types/id.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,15 @@

#pragma once

#include <bsoncxx/v1/types/id-fwd.hpp>
#include <bsoncxx/v1/types/id-fwd.hpp> // IWYU pragma: export

//

#include <bsoncxx/v1/detail/prelude.hpp>

#include <bsoncxx/v1/config/export.hpp>

#include <cstdint>
#include <string>

namespace bsoncxx {
Expand Down
4 changes: 2 additions & 2 deletions src/bsoncxx/include/bsoncxx/v1/types/value.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

#pragma once

#include <bsoncxx/v1/types/value-fwd.hpp>
#include <bsoncxx/v1/types/value-fwd.hpp> // IWYU pragma: export

//

Expand All @@ -29,7 +29,7 @@
#include <bsoncxx/v1/config/export.hpp>
#include <bsoncxx/v1/detail/macros.hpp>
#include <bsoncxx/v1/stdx/string_view.hpp>
#include <bsoncxx/v1/types/view.hpp>
#include <bsoncxx/v1/types/view.hpp> // IWYU pragma: export

#include <array>
#include <chrono>
Expand Down
12 changes: 6 additions & 6 deletions src/bsoncxx/include/bsoncxx/v1/types/view.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,21 +14,21 @@

#pragma once

#include <bsoncxx/v1/types/view-fwd.hpp>
#include <bsoncxx/v1/types/view-fwd.hpp> // IWYU pragma: export

//

#include <bsoncxx/v1/detail/prelude.hpp>

#include <bsoncxx/v1/array/view.hpp>
#include <bsoncxx/v1/array/view.hpp> // IWYU pragma: export
#include <bsoncxx/v1/config/export.hpp>
#include <bsoncxx/v1/decimal128.hpp>
#include <bsoncxx/v1/decimal128.hpp> // IWYU pragma: export
#include <bsoncxx/v1/detail/macros.hpp>
#include <bsoncxx/v1/detail/type_traits.hpp>
#include <bsoncxx/v1/document/view.hpp>
#include <bsoncxx/v1/oid.hpp>
#include <bsoncxx/v1/document/view.hpp> // IWYU pragma: export
#include <bsoncxx/v1/oid.hpp> // IWYU pragma: export
#include <bsoncxx/v1/stdx/string_view.hpp>
#include <bsoncxx/v1/types/id.hpp>
#include <bsoncxx/v1/types/id.hpp> // IWYU pragma: export

#include <chrono>
#include <cstdint>
Expand Down
2 changes: 1 addition & 1 deletion src/bsoncxx/include/bsoncxx/v_noabi/bsoncxx/array/element-fwd.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

#pragma once

#include <bsoncxx/v1/element/view-fwd.hpp>
#include <bsoncxx/v1/element/view-fwd.hpp> // IWYU pragma: export

#include <bsoncxx/config/prelude.hpp>

Expand Down
4 changes: 2 additions & 2 deletions src/bsoncxx/include/bsoncxx/v_noabi/bsoncxx/array/element.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,15 @@

//

#include <bsoncxx/v1/element/view.hpp>
#include <bsoncxx/v1/element/view.hpp> // IWYU pragma: export

#include <cstddef>
#include <cstdint>

#include <bsoncxx/array/view-fwd.hpp>
#include <bsoncxx/types/bson_value/view-fwd.hpp>

#include <bsoncxx/document/element.hpp>
#include <bsoncxx/document/element.hpp> // IWYU pragma: export

#include <bsoncxx/config/prelude.hpp>

Expand Down
2 changes: 1 addition & 1 deletion src/bsoncxx/include/bsoncxx/v_noabi/bsoncxx/array/value-fwd.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

#pragma once

#include <bsoncxx/v1/array/value-fwd.hpp>
#include <bsoncxx/v1/array/value-fwd.hpp> // IWYU pragma: export

#include <bsoncxx/config/prelude.hpp>

Expand Down
2 changes: 1 addition & 1 deletion src/bsoncxx/include/bsoncxx/v_noabi/bsoncxx/array/view-fwd.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

#pragma once

#include <bsoncxx/v1/array/view-fwd.hpp>
#include <bsoncxx/v1/array/view-fwd.hpp> // IWYU pragma: export

#include <bsoncxx/config/prelude.hpp>

Expand Down
2 changes: 1 addition & 1 deletion src/bsoncxx/include/bsoncxx/v_noabi/bsoncxx/array/view.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

//

#include <bsoncxx/v1/array/view.hpp>
#include <bsoncxx/v1/array/view.hpp> // IWYU pragma: export

#include <cstddef>
#include <cstdint>
Expand Down
2 changes: 1 addition & 1 deletion src/bsoncxx/include/bsoncxx/v_noabi/bsoncxx/config/config.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
// limitations under the License.

// For backward compatibility.
#include <bsoncxx/v1/config/config.hpp>
#include <bsoncxx/v1/config/config.hpp> // IWYU pragma: export

///
/// @file
Expand Down
2 changes: 1 addition & 1 deletion src/bsoncxx/include/bsoncxx/v_noabi/bsoncxx/config/export.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
// limitations under the License.

// For backward compatibility.
#include <bsoncxx/v1/config/export.hpp>
#include <bsoncxx/v1/config/export.hpp> // IWYU pragma: export

///
/// @file
Expand Down
2 changes: 1 addition & 1 deletion src/bsoncxx/include/bsoncxx/v_noabi/bsoncxx/config/postlude.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

#include <bsoncxx/v1/detail/postlude.hpp>
#include <bsoncxx/v1/detail/postlude.hpp> // IWYU pragma: export

///
/// @file
Expand Down
12 changes: 6 additions & 6 deletions src/bsoncxx/include/bsoncxx/v_noabi/bsoncxx/config/prelude.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@
// See the License for the specific language governing permissions and
// limitations under the License.

#include <bsoncxx/v1/detail/prelude.hpp>
#include <bsoncxx/v1/detail/prelude.hpp> // IWYU pragma: export

#include <bsoncxx/config/compiler.hpp>
#include <bsoncxx/config/config.hpp>
#include <bsoncxx/config/export.hpp>
#include <bsoncxx/config/util.hpp>
#include <bsoncxx/config/version.hpp>
#include <bsoncxx/config/compiler.hpp> // IWYU pragma: export
#include <bsoncxx/config/config.hpp> // IWYU pragma: export
#include <bsoncxx/config/export.hpp> // IWYU pragma: export
#include <bsoncxx/config/util.hpp> // IWYU pragma: export
#include <bsoncxx/config/version.hpp> // IWYU pragma: export

///
/// @file
Expand Down
2 changes: 1 addition & 1 deletion src/bsoncxx/include/bsoncxx/v_noabi/bsoncxx/config/version.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
// limitations under the License.

// For backward compatibility.
#include <bsoncxx/v1/config/version.hpp>
#include <bsoncxx/v1/config/version.hpp> // IWYU pragma: export

///
/// @file
Expand Down
2 changes: 1 addition & 1 deletion src/bsoncxx/include/bsoncxx/v_noabi/bsoncxx/decimal128-fwd.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

#pragma once

#include <bsoncxx/v1/decimal128-fwd.hpp>
#include <bsoncxx/v1/decimal128-fwd.hpp> // IWYU pragma: export

#include <bsoncxx/config/prelude.hpp>

Expand Down
2 changes: 1 addition & 1 deletion src/bsoncxx/include/bsoncxx/v_noabi/bsoncxx/decimal128.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

//

#include <bsoncxx/v1/decimal128.hpp>
#include <bsoncxx/v1/decimal128.hpp> // IWYU pragma: export
#include <bsoncxx/v1/detail/type_traits.hpp>

#include <cstdint>
Expand Down
2 changes: 1 addition & 1 deletion src/bsoncxx/include/bsoncxx/v_noabi/bsoncxx/document/element-fwd.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

#pragma once

#include <bsoncxx/v1/element/view-fwd.hpp>
#include <bsoncxx/v1/element/view-fwd.hpp> // IWYU pragma: export

#include <bsoncxx/config/prelude.hpp>

Expand Down
2 changes: 1 addition & 1 deletion src/bsoncxx/include/bsoncxx/v_noabi/bsoncxx/document/element.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

//

#include <bsoncxx/v1/element/view.hpp>
#include <bsoncxx/v1/element/view.hpp> // IWYU pragma: export

#include <cstddef>
#include <cstdint>
Expand Down
2 changes: 1 addition & 1 deletion src/bsoncxx/include/bsoncxx/v_noabi/bsoncxx/document/value-fwd.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

#pragma once

#include <bsoncxx/v1/document/value-fwd.hpp>
#include <bsoncxx/v1/document/value-fwd.hpp> // IWYU pragma: export

#include <bsoncxx/config/prelude.hpp>

Expand Down
Loading