Skip to content

test: Fix TODO by adding Pattern type to BSON codec test #1830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

test: Fix TODO by adding Pattern type to BSON codec test #1830

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
beddada
docs: Fix typo in README.md (regulary -> regularly)
HJC96 Oct 16, 2025
03535c4
test: Fix TODO by adding Pattern type to BSON codec test
HJC96 Oct 20, 2025
4d401a7
Merge branch 'main' into fix/test-pattern-codec
HJC96 Oct 21, 2025
133f520
Merge branch 'main' into fix/test-pattern-codec
HJC96 Oct 21, 2025
404648b
Merge branch 'main' into fix/test-pattern-codec
HJC96 Oct 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion bson/src/test/unit/org/bson/codecs/DocumentCodecTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import org.bson.BsonBinaryWriter;
import org.bson.BsonInt32;
import org.bson.BsonObjectId;
import org.bson.BsonRegularExpression;
import org.bson.ByteBufNIO;
import org.bson.Document;
import org.bson.BinaryVector;
Expand All @@ -44,6 +45,7 @@
import java.util.Date;
import java.util.HashSet;
import java.util.List;
import java.util.regex.Pattern;

import static java.util.Arrays.asList;
import static org.junit.jupiter.api.Assertions.assertEquals;
Expand Down Expand Up @@ -84,14 +86,20 @@ public void testPrimitiveBSONTypeCodecs() throws IOException {
doc.put("vectorFloat", BinaryVector.floatVector(new float[]{1.1f, 2.2f, 3.3f}));
doc.put("vectorInt8", BinaryVector.int8Vector(new byte[]{10, 20, 30, 40}));
doc.put("vectorPackedBit", BinaryVector.packedBitVector(new byte[]{(byte) 0b10101010, (byte) 0b01010101}, (byte) 3));
// doc.put("pattern", Pattern.compile("^hello")); // TODO: Pattern doesn't override equals method!

Pattern pattern = Pattern.compile("^hello");
doc.put("pattern", pattern);
doc.put("null", null);

documentCodec.encode(writer, doc, EncoderContext.builder().build());

BsonInput bsonInput = createInputBuffer();
Document decodedDocument = documentCodec.decode(new BsonBinaryReader(bsonInput), DecoderContext.builder().build());

BsonRegularExpression decodedPattern = (BsonRegularExpression) decodedDocument.remove("pattern");
doc.remove("pattern");
assertEquals(doc, decodedDocument);
assertEquals(pattern.pattern(), decodedPattern.getPattern());
}

@Test
Expand Down