[PHPC-2647] Out-of-source build: Don't necessarily generate flies in the source tree #1893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing an out-of-source build, certain generated headers are written into the build tree. The directories containing these headers need to be added as #include search paths for the build to succeed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset modifies an AC_CONFIG_FILES directive to configure some of mongoc's files using relative paths. IIUC, using relative paths (instead of absolute ones) will make it read the file relative to the
configurescript, but write the file with the same name relative to the$PWDof theconfigureexecution. This allows theconfigurescript to leave the source tree more pristine.To support this, the directories that are (possibly) generated by AC_CONFIG_FILES needs to be added as
#includesearch paths. (The search directories are added based on$PWD, which feels somewhat brittle (is there a better autotools/autoconf variable to be used here? I couldn't seem to make it work otherwise.).)(I'm not sure if there is an existing relevant Jira ticket for out-of-source build support tasks, so I created PHPC-2647 for this.)