-
Notifications
You must be signed in to change notification settings - Fork 147
LangChain Compability Restored #442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
serengil
wants to merge
23
commits into
neo4j:main
Choose a base branch
from
serengil:sefik/langchain-compability
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
595b0f0
langchain compatible llminterfacev2 interface created
serengil 1b4c339
langchain compatible methods added to openai
serengil ab08ca1
broken test cases sorted
serengil da94032
brand new tests for llm interface v2
serengil 2fc6db8
vertex ai started to support llm interface v2
serengil 6a69656
brand new test cases added
serengil bdae480
invoke with tools method is not mandatory
serengil 0710a27
llminterfacev2 support added to ollama
serengil db997da
llm interface v2 supported in mistralai
serengil 8c324ab
llm interface v2 support added to cohere
serengil 053f70f
llm interface v2 support added to anthropic
serengil 1a45c4c
more tests for llminterfacev2
serengil be9bba1
mypy fixes
serengil c38ba4c
test_openai_llm possibly failed because of import in ci cd
serengil ce86150
Attempt CI/CD-compatible async mock for OpenAILLM tests
serengil 0e94ddd
Attempt CI/CD-safe async mock for OpenAILLM v1 test
serengil 1c05c9d
restoring graphrag e2e tests for v1
serengil e2dc9de
existing e2e test for graphrag sorted
serengil 85a478a
create message history only if langchain compatible branch
serengil abf0efa
typo in docstring
serengil b951fe6
avoid repeated langchain compatible check code
serengil 6fbb2e5
avoid to create vector idx and fulltext with same property
serengil b7cc001
avoid to create vector idx and fulltext with same property
serengil File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes seem to be related to line length only, are there made on purpose? (asking because I know Nathalie had some issues about this in the past)
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, pylint was warning about that line is too long. Autolinter in my ide splitted this line to many lines. I can revert them back if you think it may cause any issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just that the next person pushing to the repo will have to make the opposite change, so we should agree on a convention. Is this something we should add to a config file in the repo?