Skip to content

Replica flush dirty buffers on clean exit #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: REL_14_STABLE_neon
Choose a base branch
from
Open

Replica flush dirty buffers on clean exit #766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2a5a5f
c
Sep 15, 2025
e5bac9c
c
Sep 16, 2025
a64a906
Merge branch 'REL_14_STABLE_neon' of https://github.com/neondatabase/…
Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/backend/access/transam/xlog.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ restore_running_xacts_callback_t restore_running_xacts_callback;
set_lwlsn_db_hook_type set_lwlsn_db_hook = NULL;
set_lwlsn_relation_hook_type set_lwlsn_relation_hook = NULL;
set_max_lwlsn_hook_type set_max_lwlsn_hook = NULL;
flush_dirty_buffers_hook_type flush_dirty_buffers_hook = NULL;

/*
* Number of WAL insertion locks to use. A higher value allows more insertions
Expand Down Expand Up @@ -10163,10 +10164,20 @@ CreateRestartPoint(int flags)
ControlFile->time = (pg_time_t) time(NULL);
UpdateControlFile();
LWLockRelease(ControlFileLock);

if (flush_dirty_buffers_hook)
{
flush_dirty_buffers_hook(flags);
}
}
return false;
}

if (flush_dirty_buffers_hook)
{
flush_dirty_buffers_hook(flags);
}

/*
* Update the shared RedoRecPtr so that the startup process can calculate
* the number of segments replayed since last restartpoint, and request a
Expand Down
3 changes: 3 additions & 0 deletions src/include/access/xlog.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,9 @@ extern set_lwlsn_db_hook_type set_lwlsn_db_hook;
extern set_lwlsn_relation_hook_type set_lwlsn_relation_hook;
extern set_max_lwlsn_hook_type set_max_lwlsn_hook;

typedef void (*flush_dirty_buffers_hook_type)(int flags);
extern flush_dirty_buffers_hook_type flush_dirty_buffers_hook;

extern XLogRecPtr GetRedoStartLsn(void);

extern bool PromoteIsTriggered(void);
Expand Down
Loading