Few Updates to Prep for SSoT Refactor #303
Open
+1,036
−710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """Document keyword arguments that were used to initialize Adapter.""" | ||
| meta_kwargs = deepcopy(kwargs) | ||
| instance = super().__new__(cls) | ||
| instance._meta_kwargs = meta_kwargs |
There was a problem hiding this comment.
Anything we can/should document about this enhancement?
There was a problem hiding this comment.
Sure, can't hurt to have it mentioned but I'm not sure where would be a good place.
There was a problem hiding this comment.
What motivated regenerating the lock file?
There was a problem hiding this comment.
All the dependabot PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some pieces required for enabling future capabilities in the Nautobot SSoT App. Mainly this has the keyword arguments that are passed when initializing an Adapter recorded in the
_meta_kwargsattribute. A side-effect of this was that setting a default dict_type for OrderedDefaultDict was required for the deepcopy operation.