-
Notifications
You must be signed in to change notification settings - Fork 121
chore: deprecate support for Alpine 3.19 #1362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: waf-release-5.10
Are you sure you want to change the base?
Conversation
✅ Deploy Preview will be available once build job completes!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM! Left a comment about the Dockerfile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is no longer in use.
See the new set of Dockerfiles in the folder /content/include/waf/dockerfiles/.
| | RHEL / Rocky Linux 9 | _app-protect-ip-intelligence_ | | ||
| | Operating system | Install command | | ||
| | ----------------------------------- | --------------------------------------- | | ||
| | Alpine Linux | apk add app-protect-ip-intelligence | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think that there is no alpine on that version...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can remove it but I left it for older versions. Another option is to add (deprecated) next to Alpine
Proposed changes
Checklist
Before sharing this pull request, I completed the following checklist:
Footnotes
Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content. ↩