Skip to content

Conversation

@tataruty
Copy link
Contributor

@tataruty tataruty commented Nov 3, 2025

Proposed changes

Guide how to turn data plane access_log OFF and how to configure custom log_format for access logs

Checklist

Before sharing this pull request, I completed the following checklist:

Footnotes

  1. Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content.

@tataruty tataruty requested a review from a team as a code owner November 3, 2025 12:42
@github-actions github-actions bot added documentation Improvements or additions to documentation product/ngf Issues related to NGINX Gateway Fabric labels Nov 3, 2025
@tataruty tataruty requested a review from ciarams87 November 3, 2025 12:44
@tataruty tataruty changed the base branch from main to ngf-release-2.3 November 3, 2025 12:57
Copy link
Contributor

@shaun-nx shaun-nx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Nice work! 🎉

Copy link
Member

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: single edit suggestion to remove a horizontal line, which we don't use anymore.


{{< call-out "note" >}} File destinations in `logging.accessLog.path` are not currently supported. Any value other than `off` is replaced with `/dev/stdout`. {{< /call-out >}}

---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
---

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ADubhlaoich won't it be confusing since we still have it in this document above and below this new text?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @ADubhlaoich . Up to you to accept or push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation product/ngf Issues related to NGINX Gateway Fabric

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants