Skip to content

Conversation

@ciarams87
Copy link
Contributor

Proposed changes

Upgrade go to the latest version

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@ciarams87 ciarams87 requested a review from a team as a code owner November 5, 2025 22:37
@github-actions github-actions bot added dependencies Pull requests that update a dependency file chore Pull requests for routine tasks labels Nov 5, 2025
@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.05%. Comparing base (ab00eed) to head (e00bfe4).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4222      +/-   ##
==========================================
+ Coverage   86.03%   86.05%   +0.01%     
==========================================
  Files         131      131              
  Lines       14167    14167              
  Branches       35       35              
==========================================
+ Hits        12189    12191       +2     
+ Misses       1775     1773       -2     
  Partials      203      203              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

module github.com/nginx/nginx-gateway-fabric/v2/tests

go 1.24.2
go 1.25.3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't technically update our build version, we already use latest for that. This just enforces that this version is required to build our binary, which isn't really necessary unless there's a feature or something in that version that we require to compile.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(agent is using an older version of Go, but not us)

@ciarams87 ciarams87 closed this Nov 6, 2025
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks dependencies Pull requests that update a dependency file

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants