Implement Library Instrumentation for Apache Iceberg #15114
+879
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jaydeluca
reviewed
Nov 4, 2025
...rary/src/main/java/io/opentelemetry/instrumentation/iceberg/v1_8/IcebergMetricsReporter.java
Outdated
Show resolved
Hide resolved
.../library/src/main/java/io/opentelemetry/instrumentation/iceberg/v1_8/ScanMetricsBuilder.java
Outdated
Show resolved
Hide resolved
.../library/src/test/java/io/opentelemetry/instrumentation/iceberg/v1_8/IcebergLibraryTest.java
Outdated
Show resolved
Hide resolved
.../library/src/test/java/io/opentelemetry/instrumentation/iceberg/v1_8/IcebergLibraryTest.java
Outdated
Show resolved
Hide resolved
Comment on lines
+7
to
+11
| implementation("org.apache.iceberg:iceberg-core:1.8.1") { | ||
| artifact { | ||
| classifier = "tests" | ||
| } | ||
| } |
There was a problem hiding this comment.
why is this second implementation needed?
There was a problem hiding this comment.
In the abstract unit test class AbstractIcebergTest, I am using the public classes TestTables and TestTable that are defined in the src/test/java directory of the iceberg core project, so the second implementation is meant to give me access to these classes in the unit tests of the testing project.
As a side note: I am not really an expert in Gradle, so it could really be that a better approach exists...
Co-authored-by: Jay DeLuca <jaydeluca4@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at creating library instrumentation for Apache Iceberg scan metrics. The figure above summarizes the planned solution (the green classes constitute the instrumentation).
The Apache Iceberg API currently emits two types of metrics:
ScanMetricsthat are emitted when a table scan is executed, andCommitMetricsthat are emitted when modifications to the data or metadata are executed, e.g., insert, update, delete, drop column, time travel, etc.ScanMetricsare straightforward to report using a custom reporter. We can programmatically inject such a reporter into an exitingScanobject as described here. On the contrary,CommitMetricsare difficult to report using a custom reporter due to the absence of a programmatical interface to inject such a reporter. A configuration-based approach exists for this purpose as described here. This PR focuses onScanMetricsonly and creates a library-based instrumentation for them.CommitMetricsand agent-based instrumentation will be the subject of future PRs. Therefore, this PR partially solves #15113