feat: Add completion attribute to ContentFilterFinishReasonError for parity with LengthFinishReasonError #2730
+91
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When
finish_reason == "content_filter", the SDK raisesContentFilterFinishReasonErrorwithout providing access to the underlyingChatCompletionobject. This makes it impossible to:completion.usageThis is inconsistent with
LengthFinishReasonError, which includescompletionas a public attribute.Solution
Modified
ContentFilterFinishReasonErrorto accept and exposecompletionparameter, matching the pattern established byLengthFinishReasonError.Changes:
ContentFilterFinishReasonErrorconstructor to acceptcompletionparametercompletioncompletion_snapshotBackward Compatibility
Existing try/except blocks will continue to work. The only breaking change would be code that manually instantiates
ContentFilterFinishReasonError()without parameters, which is not a realistic use case.Related Issues
Example Usage
Testing
Added two new tests:
test_parse_content_filter_includes_completion: Verifies completion access and usage infotest_parse_content_filter_backward_compatibility: Ensures existing code still worksAll tests pass including existing
LengthFinishReasonErrortests.