Fix: Correct parameter passing in vector_stores poll() methods #2735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Fixes openai#2717 The poll() methods in both Files and FileBatches were passing IDs as positional arguments instead of named parameters when calling retrieve(). This causes TypeError when retrieve() tries to match parameters, since the method signature expects named parameters. Fixed in 4 locations: - FileBatches.poll() (sync) - AsyncFileBatches.poll() (async) - Files.poll() (sync) - AsyncFiles.poll() (async) Changed from positional to named parameters: - batch_id, -> batch_id=batch_id, - file_id, -> file_id=file_id,
yashwantbezawada
force-pushed
the
fix/vector-stores-poll-params-clean
branch
from
b5b412a to
a458faa
Compare
|
Can you provide a minimal reproducible example how we can get the error? The current implementation works for me, and it seems like the first argument can be positional, for the both classes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes being requested
Fixes #2717 -
poll()methods in vector_stores now pass parameters correctlyThe
poll()methods in bothFilesandFileBatcheswere passing IDs as positional arguments instead of named parameters when callingretrieve(). This causesTypeErrorbecauseretrieve()expects named parameters.Fixed in 4 locations:
FileBatches.poll()(sync) - line 295AsyncFileBatches.poll()(async) - line 632Files.poll()(sync) - line 337AsyncFiles.poll()(async) - line 745Changed from:
To:
Additional context & links
Issue: #2717
Affected: All users calling
poll()on vector store files or file batchesImpact: Method was failing with TypeError when trying to poll for completion status