fix(openapi-react-query): mutation results type #2519
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds proper types to the useMutation's onMutateResults fields which are used in
onSettled,onError& return object of this hook.The open issue regarding this bug: #2518
I ended up digging further & this seems to fix it, but looking forward for a second pair of eyes to check that my fix is correct 🙂
Here I moved the
Optionstype definition from the generic parameters to the actualoptionsparameter themselves, thus not setting theUseMutationOptions'sTOnMutateResultto the defaultunknown.How to Review
Checklist
docs/updated (if necessary)pnpm run update:examplesrun (only applicable for openapi-typescript)