Skip to content

fix: explicitly use remote addr for unicast UDP queries #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: explicitly use remote addr for unicast UDP queries #52

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
440f12a
fix: explicitly use remote addr for unicast UDP queries
thegamecracks Oct 27, 2025
22ee7ca
Merge branch 'main' into udpclient-remote-addr
BattlefieldDuck Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions opengsq/protocol_socket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,15 +153,25 @@ async def communicate(protocol: ProtocolBase, data: bytes, source_port: int = No
udpClient.bind_port(source_port)
udpClient.settimeout(protocol._timeout)

if protocol._allow_broadcast:
local_addr = ('0.0.0.0', source_port if source_port else 0)
remote_addr = None
sendto_addr = (protocol._host, protocol._port)
else:
local_addr = ('0.0.0.0', source_port) if source_port else None
remote_addr = (protocol._host, protocol._port)
sendto_addr = None

loop = asyncio.get_running_loop()
transport, protocol_instance = await loop.create_datagram_endpoint(
lambda: Socket.Protocol(protocol._timeout), # Use public Protocol class
local_addr=('0.0.0.0', source_port if source_port else 0),
local_addr=local_addr,
remote_addr=remote_addr,
allow_broadcast=protocol._allow_broadcast
)

try:
transport.sendto(data, (protocol._host, protocol._port))
transport.sendto(data, sendto_addr)
return await protocol_instance.recv()
finally:
transport.close()
Expand Down