Fix cluster name parsing logic #105
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| name: "IPAddress", | ||
| host: "https://192.168.1.1:6443", | ||
| expectedName: "192", // The function only extracts the first part of the IP address | ||
| expectedName: "192.168.1.1", // The function only extracts the first part of the IP address |
There was a problem hiding this comment.
The comment here is a bit misleading since the whole IP address is now expected. Can you remove the comment please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The PR fixes the
metric.attributes.clusterdimensions to provide the whole hostname, as with the current parsing logic, only a subset (mainly only theapistring) of the hostname is presented to the end user (on the respective backend). The information is not particularly useful if you want to determine which cluster the metric originates from, hence the current PR proposal:For example, the following cluster
https://api.c-123456.stage.kyma.ondemand.com, results in justapion the backend. The same goes for MCP cluster naming convention as well.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: