feat: filter button for graph view #354
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lasserich
requested review from
Hubert-Szczepanski-SAP and
andreaskienle
and removed request for
andreaskienle
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the graph visualization UI to use a popover-based filter menu instead of radio buttons, updates edge styling, and introduces semi-transparent node backgrounds based on border colors. The default color grouping is also changed from 'provider' to 'source'.
- Replaced the radio button panel with a popover filter button for color grouping selection
- Changed edge styling from arrow markers to solid strokes
- Introduced semi-transparent node backgrounds derived from border colors
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/components/Graphs/useGraph.ts | Removed MarkerType import, added semi-transparent node backgrounds, and replaced arrow markers with styled edges |
| src/components/Graphs/Graph.tsx | Replaced radio button panel with popover-based filter menu, changed default colorBy to 'source' |
| src/components/Graphs/Graph.module.css | Added styles for the new top-right legend container, filter icon, and popover button layout |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@andreaskienle I have fixed the dark mode now. Maybe you can have another look. :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
