Tests for resources #360
Open
Tests for resources #360
+340
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Why Edit functionality is not fully tested
Edit Resource tests are intentionally limited to basic initialization checks.
Multiple layers - The edit flow involves: openInAside, YamlSidePanel, YamlViewer, Monaco Editor, and onApply callback. Each layer requires complex setup and mocking.
Splitter Context complexity - Edit opens resources in a side panel managed by SplitterContext. This context cannot be easily mocked in Cypress component.
YAML editor (Monaco Editor) is a also complex to be mocked.
We verify the basics work, we should cover it in E2E
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: