fix: add Buffer shim if is not globally available, adjust process and AsyncLocalStorage shims to only be applied when not available #3222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… AsyncLocalStorage shims to only be applied when not available
📊 Package size report 0.01%↑
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
pieh
commented
Oct 31, 2025
Comment on lines
+8
to
+10
| if (typeof process === 'undefined') { | ||
| globalThis.process = (await import('node:process')).default | ||
| } |
There was a problem hiding this comment.
process is available in deno 2, not in deno 1
mrstork
approved these changes
Oct 31, 2025
pieh
commented
Oct 31, 2025
Comment on lines
+12
to
+14
| if (typeof AsyncLocalStorage === 'undefined') { | ||
| globalThis.AsyncLocalStorage = (await import('node:async_hooks')).AsyncLocalStorage | ||
| } |
There was a problem hiding this comment.
This is overall not globally available - it seems like Next.js quirk to expect it to be globally defined, checked if it is available just to be in line with other shims here
pieh
commented
Oct 31, 2025
Comment on lines
+16
to
+18
| if (typeof Buffer === 'undefined') { | ||
| globalThis.Buffer = (await import('node:buffer')).Buffer | ||
| } |
There was a problem hiding this comment.
this is fun one - Buffer is not globally defined in deno 1.39.0, 1.46.3 or 2.2.4 (from tested versions), but is available in 2.4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We discovered some problems when trying to bump deno version in #3221 which seemed to require adding
Bufferglobal shim. While doing so I figured it might make sense to only try to apply global shims conditionally if they things are not globally available already