improve: complete comparable resource version configs #3027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
metacosm
changed the title
xstefank
approved these changes
Nov 3, 2025
shawkins
approved these changes
Nov 3, 2025
metacosm
requested changes
Nov 3, 2025
| /** | ||
| * true if we can consider resource versions as integers, therefore it is valid to compare them | ||
| */ | ||
| boolean comparableResourceVersion() default DEFAULT_COMPARABLE_RESOURCE_VERSION; |
There was a problem hiding this comment.
javadoc could use an @since tag
| return this; | ||
| } | ||
|
|
||
| public Builder withComparableResourceVersions(boolean comparableResourceVersions) { |
There was a problem hiding this comment.
Method name should match the annotation field (i.e. versions vs version)
| * @param value true if internal algorithms can use metadata.resourceVersion as a numeric value. | ||
| * @return this | ||
| */ | ||
| @Deprecated(forRemoval = true) |
There was a problem hiding this comment.
Not sure we can remove this method, yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.