-
Notifications
You must be signed in to change notification settings - Fork 68
🌱 Upgrade compatible bingo binaries ( kind/kustomize/opm/envtest ) #2306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Upgrade compatible bingo binaries ( kind/kustomize/opm/envtest ) #2306
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates several development tool dependencies to newer versions, including kustomize, operator-sdk, opm, and their transitive dependencies. The changes also update the Go version requirement to 1.24.6 across multiple module files and remove some dependency replace directives that are no longer needed.
Key changes:
- Updates kustomize from v5.6.0 to v5.7.1
- Updates operator-sdk from v1.39.1 to v1.41.1
- Updates opm from v1.51.0 to v1.60.0
- Updates Go version from 1.24.0/1.23.x to 1.24.6
- Removes various
replacedirectives in module files - Updates numerous transitive dependencies in sum files
Reviewed Changes
Copilot reviewed 12 out of 14 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.bingo/variables.env |
Updates tool version variables for kustomize, operator-sdk, and opm |
.bingo/Variables.mk |
Updates makefile variables and build commands for the updated tool versions |
.bingo/*.mod |
Updates Go version to 1.24.6 and removes obsolete replace directives |
.bingo/*.sum |
Updates transitive dependency checksums for the updated tools |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2306 +/- ##
==========================================
+ Coverage 74.23% 74.30% +0.07%
==========================================
Files 90 90
Lines 7014 7014
==========================================
+ Hits 5207 5212 +5
+ Misses 1398 1394 -4
+ Partials 409 408 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- kind: v0.30.0 - kustomize: v5.7.1 - opm: v1.60.0 - setup-envtest: capped at v0.0.0-20250620151452-b9a9ca01fd37 (newer commits demand Go ≥ 1.25)
f67daf2 to
15bf57d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 9 out of 11 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @echo "(re)installing $(GOBIN)/operator-sdk-v1.39.1" | ||
| @cd $(BINGO_DIR) && GOWORK=off $(GO) build -ldflags=-X=github.com/operator-framework/operator-sdk/internal/version.Version=v1.34.1 -mod=mod -modfile=operator-sdk.mod -o=$(GOBIN)/operator-sdk-v1.39.1 "github.com/operator-framework/operator-sdk/cmd/operator-sdk" | ||
| @echo "(re)installing $(GOBIN)/operator-sdk-v1.41.1" | ||
| @cd $(BINGO_DIR) && GOWORK=off $(GO) build -mod=mod -modfile=operator-sdk.mod -o=$(GOBIN)/operator-sdk-v1.41.1 "github.com/operator-framework/operator-sdk/cmd/operator-sdk" |
Copilot
AI
Nov 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The operator-sdk build command has removed the -ldflags parameter that was present in the previous version. The original command included -ldflags=-X=github.com/operator-framework/operator-sdk/internal/version.Version=v1.34.1 which set a custom version. Please verify if this version flag is still needed for operator-sdk v1.41.1 or if this change is intentional.
| @cd $(BINGO_DIR) && GOWORK=off $(GO) build -mod=mod -modfile=operator-sdk.mod -o=$(GOBIN)/operator-sdk-v1.41.1 "github.com/operator-framework/operator-sdk/cmd/operator-sdk" | |
| @cd $(BINGO_DIR) && GOWORK=off $(GO) build -mod=mod -modfile=operator-sdk.mod -ldflags="-X=github.com/operator-framework/operator-sdk/internal/version.Version=v1.41.1" -o=$(GOBIN)/operator-sdk-v1.41.1 "github.com/operator-framework/operator-sdk/cmd/operator-sdk" |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pedjak, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b470947
into
operator-framework:main
…t ) (operator-framework#2306)" This reverts commit b470947.
Uh oh!
There was an error while loading. Please reload this page.