-
Notifications
You must be signed in to change notification settings - Fork 68
🌱 (bingo): Replace deprecated github.com/everettraven/crd-diff with sigs.k8s.io/crdify for crd API checks #2307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 (bingo): Replace deprecated github.com/everettraven/crd-diff with sigs.k8s.io/crdify for crd API checks #2307
Conversation
…s.k8s.io/crdify for crd API checks
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the crd-diff tool dependency from github.com/everettraven/crd-diff v0.2.0 to sigs.k8s.io/crdify v0.5.0, migrating to a new package location and version. The change also updates the Go version requirement to 1.24.6 for the tool's module.
- Updated crd-diff tool from v0.2.0 to v0.5.0 with package migration from
github.com/everettraven/crd-difftosigs.k8s.io/crdify - Updated Go version from 1.22.5 to 1.24.6 in the crd-diff module
- Cleaned up numerous unused transitive dependencies from the sum file
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.bingo/variables.env |
Updated CRD_DIFF variable to reference v0.5.0 binary |
.bingo/crd-diff.sum |
Updated checksums with new package dependencies and removed old unused transitive dependencies |
.bingo/crd-diff.mod |
Changed module dependency from github.com/everettraven/crd-diff to sigs.k8s.io/crdify and updated Go version |
.bingo/Variables.mk |
Updated makefile variables and build commands to reference new package and version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2307 +/- ##
==========================================
- Coverage 74.23% 74.18% -0.06%
==========================================
Files 90 90
Lines 7014 7014
==========================================
- Hits 5207 5203 -4
- Misses 1398 1400 +2
- Partials 409 411 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pedjak, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
9937ae2
into
operator-framework:main
No description provided.