Skip to content

Conversation

@camilamacedo86
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings November 5, 2025 10:43
@camilamacedo86 camilamacedo86 requested a review from a team as a code owner November 5, 2025 10:43
@netlify
Copy link

netlify bot commented Nov 5, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit dc292a6
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/690b2a5568d71a0008d49eae
😎 Deploy Preview https://deploy-preview-2307--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the crd-diff tool dependency from github.com/everettraven/crd-diff v0.2.0 to sigs.k8s.io/crdify v0.5.0, migrating to a new package location and version. The change also updates the Go version requirement to 1.24.6 for the tool's module.

  • Updated crd-diff tool from v0.2.0 to v0.5.0 with package migration from github.com/everettraven/crd-diff to sigs.k8s.io/crdify
  • Updated Go version from 1.22.5 to 1.24.6 in the crd-diff module
  • Cleaned up numerous unused transitive dependencies from the sum file

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
.bingo/variables.env Updated CRD_DIFF variable to reference v0.5.0 binary
.bingo/crd-diff.sum Updated checksums with new package dependencies and removed old unused transitive dependencies
.bingo/crd-diff.mod Changed module dependency from github.com/everettraven/crd-diff to sigs.k8s.io/crdify and updated Go version
.bingo/Variables.mk Updated makefile variables and build commands to reference new package and version

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@pedjak pedjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2025
@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.18%. Comparing base (7c443eb) to head (dc292a6).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2307      +/-   ##
==========================================
- Coverage   74.23%   74.18%   -0.06%     
==========================================
  Files          90       90              
  Lines        7014     7014              
==========================================
- Hits         5207     5203       -4     
- Misses       1398     1400       +2     
- Partials      409      411       +2     
Flag Coverage Δ
e2e 45.89% <ø> (+0.03%) ⬆️
experimental-e2e 48.09% <ø> (-0.07%) ⬇️
unit 58.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort
Copy link
Contributor

tmshort commented Nov 5, 2025

/approve

@openshift-ci
Copy link

openshift-ci bot commented Nov 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pedjak, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 9937ae2 into operator-framework:main Nov 5, 2025
35 of 36 checks passed
@camilamacedo86 camilamacedo86 deleted the crddiff branch November 6, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants